We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The following public methods of kiwix::Library are conceptually const but are not declared such:
kiwix::Library
const
std::shared_ptr<Reader> getReaderById(const std::string& id); bool writeToFile(const std::string& path); bool writeBookmarksToFile(const std::string& path); unsigned int getBookCount(const bool localBooks, const bool remoteBooks); std::vector<std::string> getBooksLanguages(); std::vector<std::string> getBooksCreators(); std::vector<std::string> getBooksPublishers(); const std::vector<kiwix::Bookmark> getBookmarks(bool onlyValidBookmarks = true); BookIdCollection getBooksIds(); DEPRECATED BookIdCollection filter(const std::string& search); BookIdCollection filter(const Filter& filter); void sort(BookIdCollection& bookIds, supportedListSortBy sortBy, bool ascending); DEPRECATED BookIdCollection listBooksIds(...);
Besides, it makes sense to have const versions of the following methods:
Book& getBookById(const std::string& id); Book& getBookByPath(const std::string& path);
Is there anything that is preventing us from doing this?
The text was updated successfully, but these errors were encountered:
No. Potentially API/ABI compatibility, but we can bump the version.
Sorry, something went wrong.
veloman-yunkan
Successfully merging a pull request may close this issue.
The following public methods of
kiwix::Library
are conceptuallyconst
but are not declared such:Besides, it makes sense to have
const
versions of the following methods:Is there anything that is preventing us from doing this?
The text was updated successfully, but these errors were encountered: