const-correct kiwix::Library #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made most methods of kiwix::Library const. - Also added const versions of getBookById() and getBookByPath() methods.
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 64.39% 64.45% +0.05%
==========================================
Files 50 50
Lines 3556 3562 +6
Branches 1816 1816
==========================================
+ Hits 2290 2296 +6
Misses 1264 1264
Partials 2 2
Continue to review full report at Codecov.
|
Yes, this is a ABI break and we don't have a separated versioning of ABI/API. |
OK, but we have already bumped to 10.0.0, so we are good? |
|
Indeed. We can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487
methods.
Should we bump the libkiwix version because of this change?