Backward compatible support for IPv6 #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
==========================================
+ Coverage 40.87% 41.36% +0.49%
==========================================
Files 58 58
Lines 4223 4233 +10
Branches 2313 2316 +3
==========================================
+ Hits 1726 1751 +25
+ Misses 1024 994 -30
- Partials 1473 1488 +15 ☔ View full report in Codecov by Sentry. |
mgautierfr
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Maybe we can also set the "old" methods as deprecated
(with https://github.com/kiwix/libkiwix/blob/main/include/common.h#L7-L14)
Else, agree with this PR
It may be too soon. The nature of the enhancement is such that I feel fine with the old API staying around for some time. We can deprecate it later. |
- Restored kiwix::getNetworkInterfaces() API to the version before support for IPv6 was introduced - Renamed the new API method to kiwix::getNetworkInterfacesIPv4Or6()
The unit-tests only call the said functions and print their output which should then be examined by the maintainer.
kelson42
force-pushed
the
network_tools_backward_compatibility
branch
from
1caa1fd
to
75bddbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings backward compatibility to #1074