Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build executable #1124

Closed
sgourdas opened this issue Jun 6, 2024 · 2 comments
Closed

Unable to build executable #1124

sgourdas opened this issue Jun 6, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@sgourdas
Copy link
Collaborator

sgourdas commented Jun 6, 2024

When doing sudo make install I get the below:

src/localkiwixserver.cpp: In constructor ‘LocalKiwixServer::LocalKiwixServer(QWidget*)’:
src/localkiwixserver.cpp:44:66: error: ‘const class std::__cxx11::basic_string<char>’ has no member named ‘addr’
   44 |         QString ip = QString::fromStdString(interfacePair.second.addr);
      |                                                                  ^~~~
src/localkiwixserver.cpp: In member function ‘void LocalKiwixServer::runOrStopServer()’:
src/localkiwixserver.cpp:91:117: error: too many arguments to function ‘std::string kiwix::getBestPublicIp()’
   91 | ") ? m_ipAddress : QString::fromStdString(kiwix::getBestPublicIp(false));
      |                                                                       ^

In file included from src/localkiwixserver.cpp:4:
/usr/local/include/kiwix/tools.h:221:13: note: declared here
  221 | std::string getBestPublicIp();
      |             ^~~~~~~~~~~~~~~

Seems to be coming from #1122

@veloman-yunkan
Copy link
Collaborator

veloman-yunkan commented Jun 6, 2024

If you build libkiwix on your own, just update it. Otherwise you will have to wait until kiwix/libkiwix#1093 is merged whereupon #1122 may be reverted.

@sgourdas
Copy link
Collaborator Author

sgourdas commented Jun 6, 2024

Got it. Thank you.

@kelson42 kelson42 added this to the 2.4.0 milestone Jun 6, 2024
@kelson42 kelson42 closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants