Kiwix frontend style cleanup #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
changed the title
veloman-yunkan
force-pushed
the
kiwix_frontend_style_cleanup
branch
2 times, most recently
from
cb1e681
to
09eb8e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 38.92% 38.92%
=======================================
Files 58 58
Lines 3990 3990
Branches 2201 2201
=======================================
Hits 1553 1553
Misses 1090 1090
Partials 1347 1347 ☔ View full report in Codecov by Sentry. |
The new file kiwix.css is intended to host the intersection of index.css and taskbar.css. In this commit only font definitions have been moved into it.
Moved from index.css into kiwix.css some CSS with global effect thus making it apply to the viewer too. Extra font-size directives in taskbar.css are needed to undo the effect of 'font-size: 62.5%' now applied to the 'html' element type.
There was a slight difference (between index.css and taskbar.css) in the margin values of the UI language selector button, however the values taken from taskbar.css don't seem to have any visible impact on the welcome/library page (controlled by index.css).
Attempts to use the same color for buttons yielded poor results: viewer toolbar buttons don't look nice on the dark background used for the filter controls on the library page, whereas the light background of the viewer toolbar buttons doesn't play well with the filters on the library page which seem to be designed around the contrast effect.
veloman-yunkan
force-pushed
the
kiwix_frontend_style_cleanup
branch
from
09eb8e3
to
29c33a7
Compare
veloman-yunkan
changed the title
|
@veloman-yunkan Thank you for this PR and this attempt to fix this annoying issue. I know this is not easy. Will give it a test this WE. |
kelson42
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #917
Unfortunately, I failed to achieve consistent look-and-feel across the library page and the viewer toolbar so that they both look nice.
This PR simply reduces the gap in the look-and-feel of the two toolbars. If we want to eliminate it completely, I think that we must come up with a new design first.