Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look-and-feel mismatch between the kiwix-serve welcome page and the viewer #917

Closed
veloman-yunkan opened this issue Mar 16, 2023 · 7 comments
Assignees
Milestone

Comments

@veloman-yunkan
Copy link
Collaborator

veloman-yunkan commented Mar 16, 2023

In welcome page, font shows correctly
But it doesn't while browsing a book

This is a manifestation of a more general discrepancy in the look-and-feel of the welcome page and the viewer page. I think we better address it separately.

Please don't forget to create the ticket then.

Originally posted by @kelson42 in #910 (comment)

@kelson42
Copy link
Collaborator

What are the rationals behind this buggy behaviour?

@veloman-yunkan
Copy link
Collaborator Author

@kelson42 I don't think that there are any rationals. Simply no one paid attention to it.

@veloman-yunkan
Copy link
Collaborator Author

@kelson42 And I also want to note that the new viewer reproduced the look-and-feel of the old viewer (which by that time was already different from the welcome page).

@kelson42
Copy link
Collaborator

@veloman-yunkan In case there is a doubt, this good to go/fix on my side. We should fix before 12.1.0 release.

@kelson42 kelson42 modified the milestones: 12.1.0, 12.2.0 Jun 2, 2023
@kelson42 kelson42 modified the milestones: 13.0.0, 13.1.0 Jul 26, 2023
@kelson42
Copy link
Collaborator

@veloman-yunkan Any chance you could quickly fix this in the near future?

@veloman-yunkan
Copy link
Collaborator Author

@kelson42 I will try

@kelson42
Copy link
Collaborator

kelson42 commented Nov 4, 2023

Mostly fixed with #1009

@kelson42 kelson42 closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants