Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save page option #228

Closed
wants to merge 1 commit into from
Closed

Add save page option #228

wants to merge 1 commit into from

Conversation

jetownfeve21
Copy link
Contributor

open a file dialog to choose the path of the file which is used by the
save() method. There is no css and images.

fix #77

open a file dialog to choose the path of the file which is used by the
save() method. There is no css and images.
@mgautierfr
Copy link
Member

You are using the flag QWebEngineDownloadItem::CompleteHtmlSaveFormat when you save the page and the QT documentation says that it will save the resources.
Does the commit's comment ("There is no css and images.") is still valid ?

@mgautierfr
Copy link
Member

I think that the main problem with the images and the resources is that we use the zim:// as url scheme to intercept the request and serve the content from the zim file. (And forward the request to the native browser if this is something else than a zim://... request).
The save mechanism of Qt must be lost with this custom scheme and don't save the images and other resources.

@mgautierfr
Copy link
Member

And this PR implement the save action from the "top bar" menu. But the "Save page" from the popup menu still does nothing.

@jetownfeve21
Copy link
Contributor Author

@kelson42
Do I keep working on it ?

@kelson42
Copy link
Collaborator

I think this PR needs to be closed without been merged. Too complicated for now to get it work properly.

@kelson42 kelson42 closed this Sep 10, 2019
@kelson42 kelson42 deleted the save-page branch April 16, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "Save page"
3 participants