Implement "Save page"

[jargony]

It is not possible to save pages in Kiwix now. When you click "Save page" nothing happens.

[kelson42]

I confirm, no filepicker is even open.

[kelson42]

The problem seems a bit more complex to do that it should. We should just mask the menu item for now.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

[ShaopengLin]

So from what I have tried, sources with "zim://" and surprisingly "https://" and local files are all not downloaded. I have tried creating Zim files with different types of resources and the behavior is rather inconsistent... Only the QWebEngineViews opened with a real online website seems to work ok-ish.

I believe we will need to do our own parsing of the Html and downloading. We can download all the resources needed in the parsed HTML and then, replace the "zim://" paths with the download path in the final HTML. I confirm we can download those resources in Qt.

@veloman-yunkan @kelson42 What are your opinions on this?

[kelson42]

@ShaopengLin From your comment it seems there is a big misunderstanding (because the issue is so badly underspecified). The goal of this issue is to export an article to a PDF file. There should be a builtin tool to do that.

[ShaopengLin]

I thought we already have the print feature? It seems to work fine.

[kelson42]

@ShaopengLin It is more a usability issue. It's not straight to click on print tomsave a file. But yes, this would be the same behaviour as printing to a PDF.

[ShaopengLin]

Just to clarify, we want a more straight-forward "Save As .." action that, prints the article as PDF to the user's selected location.

[kelson42]

@ShaopengLin Yes, "Save page..." should open a filepicker dialogbox straight and propose to save the page. The filename should come from the title of the page. Default location should be the same as the last time (so location should be remembered) and "Documents" default directory. This shoudl work with HTML content, if this is an other content which is displayed then we should save the file straight.

[ShaopengLin]

@kelson42 I am not aware that we have other content display formats.Do you mean like Zims that have videos? Also by saving the file straight, do you mean the zim file?

[kelson42]

@kelson42 I am not aware that we have other content display formats.Do you mean like Zims that have videos? Also by saving the file straight, do you mean the zim file?

You can perfectly open a PNG image (or a video file) directly in a tab.

[ShaopengLin]

This shoudl work with HTML content, if this is an other content which is displayed then we should save the file straight.

I believe I would need some clarification on what "an other content" means, as well as what "saving the file straight" implies. We already have Save Meida when user open videos in fullscreen so I believe you didn't mean that.

[kelson42]

@ShaopengLin I have explained everything earlier, I don't know what to say more. Please implement what is clear and ask precise question otherwise.

[kelson42]

See kiwix/kiwix-apple#814