Implemented Category Translation

[ShaopengLin]

Fix #972

Changes:

• Displays the translated category names.
• Keeps the category keys untranslated for filtering and Remote Library querying.
• Removes unnecessary translations.

[kelson42]

@ShaopengLin I have relaunched the CI, but in case id dies again: CI should be green?

[ShaopengLin]

@kelson42 Yes it should. The failed CI doesn't seem to be up to date with the new i18n.h changes? I will check if its the problem with including paths of my own code.

[kelson42]

@ShaopengLin Strongly suspect that i18n.h is simply not distributed in libkiwix tarball.

[kelson42]

@ShaopengLin I'm a bit puzzled, for the online library, the list of categories is not retrieved from https://kiwix-tools.readthedocs.io/en/latest/kiwix-serve.html#catalog-v2-categories ? Or do we retrieve from library.kiwix.org but we translated locally? How does that work exactly for both local and remote catalogue?

At this stage it seems we have "forgotten" to implement kiwix/libkiwix#844 and we kind of workaround the problem of lack of proper API?!

[ShaopengLin]

@kelson42 I believe its from library.kiwix.org. The recieved categories doesn't seem to be translated as the API doesn't take translated categories as query parameters.

We are translating the recieved categpries manually.

[kelson42]

@ShaopengLin Root cause of the broken CI is broken PR in kiwix-build. @mgautierfr Please fix ASAP

For the rest the situation is clear now:

• For local library, we anyway only display the list of categories based on available ZIM in the local library. These ones are now translated via libkiwix (instead of directly in kiwix-desktop)
• For remote library, we download (said @ShaopengLin) the list of categories and we translate locally via libkiwix. @ShaopengLin Hopefully this piece of code can handle the fact that it can mismatch (not exactly the same list), in that case the concerned category should be displayed in English.

So this PR is really only about deporting the category translation from kiwix-desktop to libkiwix. Once kiwix/libkiwix#844 implemented, we should stop to do that for remote library. I have open an issue requesting this #1181

Otherwise LGTM, ready for code review

[mgautierfr]

@mgautierfr Please fix ASAP

This is fixed

[kelson42]

@ShaopengLin Can you please rebase and fix conflict?
@veloman-yunkan Can you please do the code review?

[kelson42]

@veloman-yunkan Are we finally ready to merge?

[ShaopengLin]

@veloman-yunkan @kelson42 I added changes that address #1185. From my testing, when the user upgrades, they will see the categories from old session files as simply the untranslated state. Once they de-select those and restart the application, those choices will be gone.

[ShaopengLin]

Different from last time, this will be what the user sees when they upgrade. Not a big deal.

[veloman-yunkan]

LGTM. Note however that I didn't test the changes.

[kelson42]

@ShaopengLin Would that be easy to just remove the filter in such situation, so user starts again on a fresh foot?

[ShaopengLin]

@kelson42 we can do that, though it will involve back porting code that ran only once. @veloman-yunkan what do you think?

[kelson42]

@ShaopengLin Let me merge this and I will test it first. This PR is too old already...

[veloman-yunkan]

@kelson42 we can do that, though it will involve back porting code that ran only once. @veloman-yunkan what do you think?

I don't think I correctly understand what you mean. After reading the category filter list from saved settings, we can simply drop entries containing the | symbol.

[ShaopengLin]

I was asking if we should do this porting as it will only be ran once. I can do a quick PR to do this then.