Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gz compression for deps archive. #716

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Use gz compression for deps archive. #716

merged 1 commit into from
Aug 14, 2024

Conversation

mgautierfr
Copy link
Member

@mgautierfr mgautierfr commented Aug 14, 2024 •
edited
Loading

It is a bit of memory waste but a lot of time win (at least on android build)

  • Cold android_arm build goes from 51 minutes to 39 minutes
  • Cold macos_all_static goes from 1h15 to 1h03
  • Warm android_arm build goes from 32 minutes to 26 minutes
  • Warm macos_all_static goes from 14 minutes to 8 minutes

@mgautierfr
Use gz compression for deps archive.
5248b4e 
It is a bit of memory waste but a lot of time win (at least
on android build)
@mgautierfr mgautierfr merged commit 08efe8e into main Aug 14, 2024
40 of 42 checks passed
@mgautierfr mgautierfr deleted the gz_dep_archive branch August 14, 2024 15:12
@kelson42
Copy link
Contributor

kelson42 commented Aug 19, 2024 •
edited
Loading

Would have been nice to update all projects as well, because this PR has broken all the CI/CD (relying on cutting-edge features of dependencies)

EDIT: dist file has not been updated!

@mgautierfr
Copy link
Member Author

Arf, that is why I wanted to not have a freezed version but always use the main version for the dl_deps_archive action.

@mgautierfr
Copy link
Member Author

It seems only libzim is impacted, other project already use the main version.
PR is openzim/libzim#911

@kelson42 kelson42 mentioned this pull request Aug 19, 2024
Merged
@kelson42
Copy link
Contributor

kelson42 commented Aug 19, 2024 •
edited
Loading

It's not! Even main rely on the dist version looks like! kiwix/kiwix-desktop#1175, as long

@mgautierfr mgautierfr mentioned this pull request Aug 19, 2024
Merged
@mgautierfr
Copy link
Member Author

Indeed, I have forget to generate the dist version. Fixed by #718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgautierfr @kelson42