-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add correct CFLAGS to hostpython3 and -fPIC flag to avoid relocation error for few recipes #2136
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!, but could you remove all the automatic black
's formatting? 😁
We already have been discussed this at #1950 and doing some massive formating as you did I don't think that it's a good idea (specially now that we have some important changes, like python3 upgrade and the removal of python2 support)...It makes it hard to review and also it's easy to miss things...for instance...this has a tox error at here which blocks our tests.
Ok, I should have re-done all the edits disabling Black auto formatting (on my Vim 🤣 ) |
469f555
to
2b18699
Compare
Fix "relocation R_386_GOTOFF" type errors on x86
Ok, everything looks like it's working now. Only thing, I don't know how to fix the Travis error... |
The Travis error is probably a flaky test, I've restarted this specific job to see.
And the PR looks good to me thanks 👍 I'll let @opacam have the final word for it |
Ok, that test went well now. |
Co-Authored-By: Pol Canelles <canellestudi@gmail.com>
Unfortunately, this does not fix the problem with I also discovered this anomaly: https://bugs.python.org/issue40261 Can any of you with a mac try it out and check if it's getting the same? |
@rubendibattista , there is an ongoing PR that fix the |
@opacam That's great. I guess those are two different problems. Maybe just land the PR about the |
As you wish, but I think that you could do it whithout waiting if you want (I don't think that we have merge conflicts), whatever you decide is fine to me 😉 |
I think this fixes #2074 (and related), at least for me on macOS. I tried to build the KivyMD Kittchen Sink app for x86, armv7 and armv8-64, and went ok on my machine (macOS Catalina) using latest NDK 21.0.6113669 and also 19c.
PS: Most of the changes are related to automatic formatting using
black
.