Add -fPIC flag to fix relocation error

Fix "relocation R_386_GOTOFF" type errors on x86
kivy · Apr 10, 2020 · e900d68 · e900d68
1 parent 5bd1465
commit e900d68
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 0 deletions.
diff --git a/pythonforandroid/recipes/Pillow/__init__.py b/pythonforandroid/recipes/Pillow/__init__.py
@@ -45,6 +45,7 @@ def get_recipe_env(self, arch=None, with_flags_in_cc=True):
         cflags += ' -I{}'.format(free_inc_dir)
         cflags += ' -I{}'.format(jpeg_inc_dir)
         cflags += ' -I{}'.format(ndk_include_dir)
+        cflags += ' -fPIC'
 
         env['LIBS'] = ' -lpng -lfreetype -lharfbuzz -ljpeg -lturbojpeg'
 

diff --git a/pythonforandroid/recipes/android/__init__.py b/pythonforandroid/recipes/android/__init__.py
@@ -19,6 +19,12 @@ class AndroidRecipe(IncludedFilesBehaviour, CythonRecipe):
     def get_recipe_env(self, arch):
         env = super().get_recipe_env(arch)
         env.update(self.config_env)
+
+        cflags = " -fPIC"
+
+        if cflags not in env["CFLAGS"]:
+            env["CFLAGS"] += cflags
+
         return env
 
     def prebuild_arch(self, arch):

diff --git a/pythonforandroid/recipes/kivy/__init__.py b/pythonforandroid/recipes/kivy/__init__.py
@@ -49,6 +49,11 @@ def get_recipe_env(self, arch):
                 join(self.ctx.bootstrap.build_dir, 'jni', 'SDL2_ttf'),
                 ])
 
+        cflags = " -fPIC"
+
+        if cflags not in env["CFLAGS"]:
+            env["CFLAGS"] += cflags
+
         return env
 
 

diff --git a/pythonforandroid/recipes/pyjnius/__init__.py b/pythonforandroid/recipes/pyjnius/__init__.py
@@ -17,6 +17,16 @@ class PyjniusRecipe(CythonRecipe):
     patches = [('sdl2_jnienv_getter.patch', will_build('sdl2')),
                ('genericndkbuild_jnienv_getter.patch', will_build('genericndkbuild'))]
 
+    def get_recipe_env(self, arch=None, with_flags_in_cc=True):
+        env = super().get_recipe_env(arch, with_flags_in_cc)
+
+        cflags = " -fPIC"
+
+        if cflags not in env["CFLAGS"]:
+            env["CFLAGS"] += cflags
+
+        return env
+
     def postbuild_arch(self, arch):
         super().postbuild_arch(arch)
         info('Copying pyjnius java class to classes build dir')