Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

docs: How to add custom monitoring resources #554

Merged
merged 2 commits into from
Aug 6, 2020
Merged

docs: How to add custom monitoring resources #554

merged 2 commits into from
Aug 6, 2020

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented Jun 4, 2020

This doc explains users how to add custom monitoring resources like
Grafana dashboards, Prometheus scrape targets using ServiceMonitors,
alerts using PrometheusRules.

@surajssd surajssd force-pushed the surajssd/how-to-add-new-dashboards branch 4 times, most recently from d5f3d89 to 515e212 Compare June 4, 2020 12:45
@surajssd surajssd force-pushed the surajssd/how-to-add-new-dashboards branch 11 times, most recently from 20f7f95 to 3cfeb31 Compare June 5, 2020 15:57
@surajssd surajssd marked this pull request as ready for review June 5, 2020 16:24
@surajssd surajssd requested a review from johananl as a code owner June 5, 2020 16:24
@surajssd surajssd requested a review from ipochi June 5, 2020 16:24
@surajssd
Copy link
Member Author

This can be a part of #480, once that is merged.

@surajssd surajssd force-pushed the surajssd/how-to-add-new-dashboards branch 4 times, most recently from e0bb22a to adf186f Compare August 3, 2020 09:41
@surajssd surajssd requested a review from invidian August 4, 2020 10:33
invidian
invidian suggested changes Aug 4, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, otherwise LGTM

docs/how-to-guides/monitoring-with-prometheus-operator.md Show resolved Hide resolved
docs/how-to-guides/monitoring-with-prometheus-operator.md Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/how-to-add-new-dashboards branch from adf186f to 3387fee Compare August 4, 2020 12:06
@invidian invidian requested a review from iaguis August 5, 2020 07:29
@invidian invidian requested a review from rata August 5, 2020 07:29
invidian
invidian previously approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's have one more person to look at it.

ipochi
ipochi suggested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@ipochi ipochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and your patience @surajssd

I've added my comments, looks largely good to me except about the custom prometheus-operator settings for adding ServiceMonitors and custom alerts.

docs/how-to-guides/monitoring-with-prometheus-operator.md Show resolved Hide resolved
docs/how-to-guides/monitoring-with-prometheus-operator.md Outdated Show resolved Hide resolved
docs/how-to-guides/monitoring-with-prometheus-operator.md Outdated Show resolved Hide resolved
docs/how-to-guides/monitoring-with-prometheus-operator.md Outdated Show resolved Hide resolved
docs/how-to-guides/monitoring-with-prometheus-operator.md Outdated Show resolved Hide resolved
docs/how-to-guides/monitoring-with-prometheus-operator.md Outdated Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/how-to-add-new-dashboards branch 2 times, most recently from bba9e84 to 5c6def8 Compare August 6, 2020 06:59
surajssd added 2 commits August 6, 2020 13:28
@surajssd
docs: How to add custom monitoring resources
83ed237 
This doc explains users how to add custom monitoring resources like
Grafana dashboards, Prometheus scrape targets using ServiceMonitors,
alerts using PrometheusRules.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd
prometheus-operator docs: Modify the verbs to simple present tense
c4a88fe 
In the "How to guide" of prometheus-operator this commit changes the
titles of sections from present continuous tense to simle present tense.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd force-pushed the surajssd/how-to-add-new-dashboards branch from 5c6def8 to c4a88fe Compare August 6, 2020 07:58
@surajssd surajssd requested a review from ipochi August 6, 2020 07:58
ipochi
ipochi approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@ipochi ipochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @surajssd

LGTM

@surajssd
Copy link
Member Author

surajssd commented Aug 6, 2020

Thanks Mateusz and Imran for your reviews :-)

@surajssd surajssd merged commit e4b4eee into master Aug 6, 2020
@surajssd surajssd deleted the surajssd/how-to-add-new-dashboards branch August 6, 2020 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ipochi ipochi ipochi approved these changes

@invidian invidian invidian left review comments

@johananl johananl Awaiting requested review from johananl

@iaguis iaguis Awaiting requested review from iaguis

@rata rata Awaiting requested review from rata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surajssd @ipochi @invidian