-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
89356d3
to
6f5b13e
Compare
|
6f5b13e
to
111bdbb
Compare
111bdbb
to
2974a0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
There are multiple capitalization problems and missing articles throughout the docs. Could you please fix these?
In addition, the writing style feels different from other docs we already have. Would you consider rephrasing the guide to help preserve a consistent tone and feel in the Lokomotive docs?
One more thing: like my feedback here, I'm getting the feeling "how to access" is too narrow as a topic for a how-to guide. I'd rather expect to see this as a section in a more complete "how to monitor Lokomotive clusters" how-to guide. |
512e7fb
to
9f7e1da
Compare
Can you be specific about what do you mean here? |
1b1b7c2
to
5970737
Compare
I guess what I wanted to say is that IMO there are language and phrasing problems throughout the PR. I will comment on specific cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort @surajssd. I've added some comments. If anything seems "arbitrary" to you or if my intention isn't clear, please talk to me.
b589895
to
961196f
Compare
1915ba5
to
7b6f720
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits, PR looks largely OK to me. However, it seems accessing monitoring require a bit of effort right now. We could perhaps improve that somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @surajssd 🙏
I've added some comments. My main issue is missing articles throughout the document. There are also a couple of places where I feel the tone/phrasing should be improved.
1471ef9
to
a1cab6c
Compare
a1cab6c
to
d6e374a
Compare
This commit adds a guide to setup monitoring stack and access it. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
d6e374a
to
6280ef0
Compare
PTAL @iaguis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and patience @surajssd !!
LGTM
All the changes mentioned were incorporated.
Fixes: #450