Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Enable e2e tests for Prometheus Operator on Packet FLUO pipeline #1153

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

invidian
Copy link
Member

@invidian invidian commented Nov 2, 2020

It should've been added in #1084.

Closes #397

Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io

@invidian
Copy link
Member Author

invidian commented Nov 3, 2020

ping @surajssd

@surajssd
Copy link
Member

surajssd commented Nov 4, 2020

@invidian what is the motivation of testing the component again in this pipeline?

@invidian
Copy link
Member Author

invidian commented Nov 4, 2020

@invidian what is the motivation of testing the component again in this pipeline?

To ensure that prometheus operator workloads converges with alternative storage, which may not be covered by Helm's --wait (e.g. if readiness probes are disabled/removed). It's a cheap sanity check.

@surajssd
Copy link
Member

surajssd commented Nov 5, 2020

Please rebase :-)

@invidian invidian force-pushed the invidian/actually-test-prometheus-on-ceph branch from e3410d7 to 2375693 Compare November 5, 2020 15:37
@invidian
Copy link
Member Author

invidian commented Nov 5, 2020

@surajssd done.

surajssd
surajssd previously approved these changes Nov 6, 2020
Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@invidian invidian force-pushed the invidian/actually-test-prometheus-on-ceph branch from 2375693 to 2083d12 Compare November 6, 2020 16:31
@invidian
Copy link
Member Author

invidian commented Nov 6, 2020

Had to rebase to include pipeline fixes.

@invidian invidian requested a review from surajssd November 6, 2020 16:32
It should've been added in #1084.

Closes #397

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@invidian invidian force-pushed the invidian/actually-test-prometheus-on-ceph branch from 2083d12 to a8f98da Compare November 6, 2020 23:07
@invidian invidian merged commit f0f0ee7 into master Nov 9, 2020
@invidian invidian deleted the invidian/actually-test-prometheus-on-ceph branch November 9, 2020 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test rook-ceph component in e2e tests
2 participants