This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Add test for rook-ceph which consumes packet_fluo pipeline #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
surajssd/add-test-code-rook-ceph
branch
3 times, most recently
from
7c02ccf to
8440d8a
Compare
surajssd
force-pushed
the
surajssd/add-test-code-rook-ceph
branch
2 times, most recently
from
fc456ec to
be4ff23
Compare
surajssd
changed the title
invidian
suggested changes
Oct 29, 2020
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // +build packet_fluo |
There was a problem hiding this comment.
What has Rook Ceph to do with packet_fluo ? It seems confusing.
There was a problem hiding this comment.
That's a pipeline build tag.
There was a problem hiding this comment.
I know what it is. I'm saying the name is confusing to me in the context of rook ceph.
surajssd
force-pushed
the
surajssd/add-test-code-rook-ceph
branch
from
be4ff23 to
78052d8
Compare
Add the tag to `Makefile` and `.golangci.yml`. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Add tests to verify various control plane components (pods) of rook-ceph are up and running. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/add-test-code-rook-ceph
branch
from
78052d8 to
8a236c9
Compare
This was referenced Nov 2, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.