-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track logged-in user and change password #913
Conversation
Sigrid maintainability feedback✅ You wrote maintainable code and achieved your objective of 3.5 stars Show detailsSigrid compared your code against the baseline of 2025-01-30. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid** to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
90c6f6c
to
73a6980
Compare
frontend/app/component/form/user/change_password/ChangePassword.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Focused mainly on backend code
Bundle ReportChanges will increase total bundle size by 8.37kB (0.44%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: abacus-frontend-esmAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 85.61% 86.66% +1.05%
==========================================
Files 225 263 +38
Lines 8933 13480 +4547
Branches 1147 1297 +150
==========================================
+ Hits 7648 11683 +4035
- Misses 1285 1703 +418
- Partials 0 94 +94 ☔ View full report in Codecov by Sentry. |
Adds user state to the ApiProvider and implement a change-password form.
#858 should me merged first
Fixes #712
Fixes #907
To Test:
Or visit https://abacus-test.nl. Note that changing a password updates the database entry, changes to a abacus-test instance are persisted (and you might not be able to login if someone else did a password change). You can always sartup a new instance.
Go to
/account/login
and login using "user" and "password", then go to/account/change-password
and change the password. Try logging in with the new password on/account/login
.