-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call login API endpoint #858
Conversation
Sigrid maintainability feedback✅ You wrote maintainable code and achieved your objective of 3.5 stars Show detailsSigrid compared your code against the baseline of 2025-01-27. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid** to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
b9b0282
to
427c841
Compare
Co-authored-by: Ellen <lionqueen94@gmail.com>
…crolled to show the button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small improvement to the rendering of the error alert, making sure the page does not scroll when there is an error and making sure the error cannot be closed (accidentally).
Fixes #710 and #711
The login form now actually calls the login API endpoint.
Also added development endpoints to create a user or to login (without any credentials).
To Test:
Or visit: https://3dd96737538f666fcb09a792a1e760435de0414b.abacus-test.nl/
Go to
/account/login
and login using "user" and "password".