Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Add Github Action to build and deploy dev image when merged to master #685

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

haynescd
Copy link
Contributor

@haynescd haynescd commented Sep 5, 2024

tag name will be post-release-(current-tag)-github-hash

Closes AD-2329

@haynescd haynescd self-assigned this Sep 5, 2024
@haynescd haynescd requested review from a team as code owners September 5, 2024 18:23
@haynescd haynescd added cicd devops Involves features of the deployment and removed cicd labels Sep 5, 2024
@haynescd haynescd force-pushed the add-github-action-to-build-dataservice branch from 324951d to 9bc2800 Compare September 5, 2024 18:35
Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting a note here to remind us that we need to wait until #684 merges, so that when this action runs itll build the image w the dev modifications

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@haynescd haynescd force-pushed the add-github-action-to-build-dataservice branch from 9bc2800 to c315bca Compare September 5, 2024 19:48
@haynescd haynescd force-pushed the add-github-action-to-build-dataservice branch from 1e975a5 to c896bd5 Compare September 5, 2024 20:36
Copy link
Member

@devbyaccident devbyaccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. If there's any issues after merge, we can handle it after.

@haynescd haynescd merged commit 56cd60c into master Sep 5, 2024
5 checks passed
@znatty22 znatty22 deleted the add-github-action-to-build-dataservice branch September 5, 2024 21:18
chris-s-friedman added a commit that referenced this pull request Sep 9, 2024
## Release 1.33.0

### Summary

- Emojis: ? x2, ✨ x3, 👨🏻‍💻 x1, ⬆️ x1
- Categories: Additions x3, Ops x1, Other Changes x3

### New features and changes

- [#686](#686) -  🐛 Update GH Action to use correct branch - [4646d95](4646d95) by [haynescd](https://github.com/haynescd)
- [#679](#679) - ✨ AD-2303 add amount and amount_units - [1ac116a](1ac116a) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#680](#680) - ✨ Add has_matched_normal and collection_id - [f3da17b](f3da17b) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#685](#685) -  👷 Add Github Action to build and deploy dev image when merged to master - [56cd60c](56cd60c) by [haynescd](https://github.com/haynescd)
- [#684](#684) - 👨🏻‍💻 Always bind all interfaces when app runs in docker-compose - [7370bbd](7370bbd) by [znatty22](https://github.com/znatty22)
- [#681](#681) - ✨ D3B-674 Add cavatica related gf fields - [182f4b2](182f4b2) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#682](#682) - ⬆️ Bump Werkzeug from 0.15.3 to 0.15.5 - [645d888](645d888) by [chris-s-friedman](https://github.com/chris-s-friedman)
chris-s-friedman added a commit that referenced this pull request Sep 9, 2024
## Release 1.33.0

### Summary

- Emojis: ? x3, ✨ x3, 👨🏻‍💻 x1, ⬆️ x1
- Categories: Additions x3, Ops x1, Other Changes x4

### New features and changes

- [#688](#688) -  🐛 Update Tag of dataservice image - [ae8831e](ae8831e) by [haynescd](https://github.com/haynescd)
- [#686](#686) -  🐛 Update GH Action to use correct branch - [4646d95](4646d95) by [haynescd](https://github.com/haynescd)
- [#679](#679) - ✨ AD-2303 add amount and amount_units - [1ac116a](1ac116a) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#680](#680) - ✨ Add has_matched_normal and collection_id - [f3da17b](f3da17b) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#685](#685) -  👷 Add Github Action to build and deploy dev image when merged to master - [56cd60c](56cd60c) by [haynescd](https://github.com/haynescd)
- [#684](#684) - 👨🏻‍💻 Always bind all interfaces when app runs in docker-compose - [7370bbd](7370bbd) by [znatty22](https://github.com/znatty22)
- [#681](#681) - ✨ D3B-674 Add cavatica related gf fields - [182f4b2](182f4b2) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#682](#682) - ⬆️ Bump Werkzeug from 0.15.3 to 0.15.5 - [645d888](645d888) by [chris-s-friedman](https://github.com/chris-s-friedman)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Involves features of the deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants