-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ AD-2303 add amount and amount_units #679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-s-friedman
force-pushed
the
vbr_updates
branch
from
August 28, 2024 18:41
4167bbe
to
57bf137
Compare
✨ Actually add the entitites 🚨 Fix linter issues ✅ add new columns to bs resource test 🗃️ add flask migration script
jenkins-kf
force-pushed
the
vbr_updates
branch
from
September 6, 2024 17:22
9d7afcd
to
5a116e4
Compare
znatty22
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
chris-s-friedman
added a commit
that referenced
this pull request
Sep 9, 2024
## Release 1.33.0 ### Summary - Emojis: ✨ x3, ⬆️ x1 - Categories: Additions x3, Ops x1 ### New features and changes - [#679](#679) - ✨ AD-2303 add amount and amount_units - [1ac116a](1ac116a) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#680](#680) - ✨ Add has_matched_normal and collection_id - [f3da17b](f3da17b) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#681](#681) - ✨ D3B-674 Add cavatica related gf fields - [182f4b2](182f4b2) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#682](#682) - ⬆️ Bump Werkzeug from 0.15.3 to 0.15.5 - [645d888](645d888) by [chris-s-friedman](https://github.com/chris-s-friedman)
Closed
chris-s-friedman
added a commit
that referenced
this pull request
Sep 9, 2024
## Release 1.33.0 ### Summary - Emojis: ? x2, ✨ x3, 👨🏻💻 x1, ⬆️ x1 - Categories: Additions x3, Ops x1, Other Changes x3 ### New features and changes - [#686](#686) - 🐛 Update GH Action to use correct branch - [4646d95](4646d95) by [haynescd](https://github.com/haynescd) - [#679](#679) - ✨ AD-2303 add amount and amount_units - [1ac116a](1ac116a) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#680](#680) - ✨ Add has_matched_normal and collection_id - [f3da17b](f3da17b) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#685](#685) - 👷 Add Github Action to build and deploy dev image when merged to master - [56cd60c](56cd60c) by [haynescd](https://github.com/haynescd) - [#684](#684) - 👨🏻💻 Always bind all interfaces when app runs in docker-compose - [7370bbd](7370bbd) by [znatty22](https://github.com/znatty22) - [#681](#681) - ✨ D3B-674 Add cavatica related gf fields - [182f4b2](182f4b2) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#682](#682) - ⬆️ Bump Werkzeug from 0.15.3 to 0.15.5 - [645d888](645d888) by [chris-s-friedman](https://github.com/chris-s-friedman)
chris-s-friedman
added a commit
that referenced
this pull request
Sep 9, 2024
## Release 1.33.0 ### Summary - Emojis: ? x3, ✨ x3, 👨🏻💻 x1, ⬆️ x1 - Categories: Additions x3, Ops x1, Other Changes x4 ### New features and changes - [#688](#688) - 🐛 Update Tag of dataservice image - [ae8831e](ae8831e) by [haynescd](https://github.com/haynescd) - [#686](#686) - 🐛 Update GH Action to use correct branch - [4646d95](4646d95) by [haynescd](https://github.com/haynescd) - [#679](#679) - ✨ AD-2303 add amount and amount_units - [1ac116a](1ac116a) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#680](#680) - ✨ Add has_matched_normal and collection_id - [f3da17b](f3da17b) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#685](#685) - 👷 Add Github Action to build and deploy dev image when merged to master - [56cd60c](56cd60c) by [haynescd](https://github.com/haynescd) - [#684](#684) - 👨🏻💻 Always bind all interfaces when app runs in docker-compose - [7370bbd](7370bbd) by [znatty22](https://github.com/znatty22) - [#681](#681) - ✨ D3B-674 Add cavatica related gf fields - [182f4b2](182f4b2) by [chris-s-friedman](https://github.com/chris-s-friedman) - [#682](#682) - ⬆️ Bump Werkzeug from 0.15.3 to 0.15.5 - [645d888](645d888) by [chris-s-friedman](https://github.com/chris-s-friedman)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See AD-2303. Adds amount and amount_units to biospecimen and to sample