Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Payment methods] A11y - Credit card name #593

Merged
merged 2 commits into from
Feb 14, 2019
Merged

[Payment methods] A11y - Credit card name #593

merged 2 commits into from
Feb 14, 2019

Conversation

dusi
Copy link
Contributor

@dusi dusi commented Feb 14, 2019 •
edited by cdolm92
Loading

📲 What

VoiceOver starts reading the credit card cell with the name of the card.

🤔 Why

Better VoiceOver experience

What is obvious to non-visually impaired users by seeing the credit card icon should be conveyed to visually impaired users using VoiceOver.

🛠 How

"Simply" concatenating the card name and card name information.

♿️ Accessibility

with VoiceOver ON

  • VoiceOver reads the credit card cell as Card name, Card ending in XXXX, Expires YYYY-MM so for example Amex, Card ending in 8431, Expires 2022-10 or Visa, Card ending in 4242, Expires 2022-09

@dusi dusi changed the title Add card name to the a11y label [Payment methods] A11y - Credit card name Feb 14, 2019
dusi
dusi commented Feb 14, 2019
View reviewed changes
KsApi/models/UserCreditCard.swift
@@ -11,6 +11,15 @@ public struct GraphUserCreditCard: Swift.Decodable {
public var formattedExpirationDate: String {
return String(expirationDate.dropLast(3))
}

public var imageName: String {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted this to where it's probably better suited.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that 👍

dusi
dusi commented Feb 14, 2019
View reviewed changes
KsApi/models/UserCreditCard.swift
case .amex, .discover, .jcb, .mastercard, .visa, .diners:
return self.rawValue.capitalized
default:
return nil
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic should return nil

dusi
dusi commented Feb 14, 2019
View reviewed changes
Library/ViewModels/CreditCardCellViewModel.swift
@@ -58,7 +66,7 @@ CreditCardCellViewModelOutputs, CreditCardCellViewModelType {
}

private func cardImage(with card: GraphUserCreditCard.CreditCard) -> UIImage? {
return image(named: "icon--" + card.type.rawValue.lowercased()) ?? image(named: "icon--generic")
return image(named: card.imageName)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, this should be more readable.

@dusi
Copy link
Contributor Author

dusi commented Feb 14, 2019

Final Accessibility pass for payment methods

@Scollaco Scollaco self-requested a review February 14, 2019 16:18
Scollaco
Scollaco approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @dusi ! I would just finish writing that comment down, as I pointed before.

KsApi/models/UserCreditCard.swift
@@ -11,6 +11,15 @@ public struct GraphUserCreditCard: Swift.Decodable {
public var formattedExpirationDate: String {
return String(expirationDate.dropLast(3))
}

public var imageName: String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that 👍

Library/ViewModels/CreditCardCellViewModel.swift Outdated
@@ -14,6 +14,9 @@ public protocol CreditCardCellViewModelOutputs {
/// Emits the card's image.
var cardImage: Signal<UIImage?, NoError> { get }

/// Emits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm something missing here? lol

Copy link
Contributor Author

@dusi dusi Feb 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMAO 😂😂😂

Did I fall asleep while writing this?

cdolm92
cdolm92 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@cdolm92 cdolm92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job on this! 🎉
✅Passed: Tested on iPhone 7, iOS 12.1.2

@dusi dusi merged commit 3f73a7a into feature-payment-methods Feb 14, 2019
@dusi dusi deleted the feature-payment-methods-a11y-card-name branch February 14, 2019 21:28
justinswart added a commit that referenced this pull request Feb 15, 2019
@justinswart
Payment methods (#597)
ccfdcaa 
* New card screen ui (#471)

* add card view controller

* transition to add new card and uibarbuttons

* settings style applied to add new card screen

* changed keyboard style for textfields

* view controller tests

* placeholder for cardholder name textfield

* Record new screenshots

* new strings, added strings as place holder and text label

* pr feedback - inferring type for cancel button tintcolor

* pr feedback - keypath, no more lenses

* swiftlint fix

* new snapshots

* Payment methods (#457)

* Stripe element add new card (#473)

* New card screen ui (#471)

* add card view controller

* transition to add new card and uibarbuttons

* settings style applied to add new card screen

* changed keyboard style for textfields

* view controller tests

* placeholder for cardholder name textfield

* Record new screenshots

* new strings, added strings as place holder and text label

* pr feedback - inferring type for cancel button tintcolor

* pr feedback - keypath, no more lenses

* swiftlint fix

* new snapshots

* new stppaymentcardtextfield showing

* wip - placeholder colors

* snapshot tests

* Email undeliverable/unverified (#478)

* Adding emailIsVerified

* Renaming GraphUserEmail

* ViewModel tests

* ChangeEmailViewController tests

* Strings, swiftlint

* Strings & new screenshots

* Cleanup

* PR comments

* PR updates

* Test naming

* pr feedback

* new snapshots

* new placeholder colors

* new snapshots

* Delete payment methods (#479)

* Add payment method deletion

* Test datasource

* Test view model

* Clean-up and address PR feedback

* Rename credit card -> payment method

* Fix test

* Add credit card implementation (#503)

* Email undeliverable/unverified (#478)

* Adding emailIsVerified

* Renaming GraphUserEmail

* ViewModel tests

* ChangeEmailViewController tests

* Strings, swiftlint

* Strings & new screenshots

* Cleanup

* PR comments

* PR updates

* Test naming

* Use correct function to log events in crash logs (#481)

* Use correct function to log events in crash logs

* Fix indentation

* changed ui colors for textfield text and font size of text label

* vm and work on enabling save

* wip- get stripe token

* wip- payment source mutation

* wip- keyboard response

* wip- getting a stripe error here

* wip- error fix w/ publishable key, error banner showing

* wip- saving with error and keyboard functionality

* wip- updating card immediately

* wip

* wip - ACs met

* wip - refactor in view model, made IDs testable, begane VM tests

* wip -refactor on vm/vmtest

* wip -refactor deleted comments on vmt

* wip -snapshot tests

* swiftlint fixes

* renaming/refactor, corrected paymentmethodstests

* pr feedback

* swiftlint fixes

* changed function name

* indentation

* Payment methods event tracking (#496)

* Reverted code that deleted SettingsNewsletters from Storyboard.swift

* swiftlint

* Reverted code to instantiate settings newsletters vc on tests

* Alphabetized storyboard enum

* Settings payments colors (#530)

* Unsupported Credit Cards (#561)

* Viewmodel logic for unsupported cards

* Tests and accessibility fixes

* Simplify add card button

* Screenshots and string updates

* Cleanup design and remove logs

* Improving comment message

* Removing filter debug builds

* Addressing PR comments

* Updating payment methods screenshots

* Screenshots

* Possible fix for alignment issues

* Moving iOS 10 handling to output signal closure

* Remove line

* Renaming

* Last cleanup

* Strings & Asset update

* Switching from unsupported to supported

* Zipcode field in Add New Card screen (#566)

* Viewmodel logic for unsupported cards

* Tests and accessibility fixes

* Simplify add card button

* Screenshots and string updates

* Cleanup design and remove logs

* Improving comment message

* Removing filter debug builds

* Addressing PR comments

* Updating payment methods screenshots

* Screenshots

* Possible fix for alignment issues

* Moving iOS 10 handling to output signal closure

* Remove line

* Renaming

* Last cleanup

* Shared styled form field

* Adding functionality for zipcode form field

* More functionality

* View model & screenshot tests

* Swiftlint

* Cleanup

* Improving test and cleanup

* PR feedback and autocapitalizing zipcode

* Regenerating ChangePassword screenshots

* [Payment methods] CVC bug fix (#574)

* wip

* wip

* wip

* wip-swiftlint

* moved CreatePaymentSourceEnvelope to its own file, Mockservice

* swiftlint fix

* deleted unnecesary debugging code

* new paymentsource temploate and vm tests

* swiftlint fix

* fixed vm test

* PR feedback

* update schema

* [Payment methods] Minor bug fixes (#579)

* tableViewIsEditing false and show banner after dismiss

* Swiftlint

* Adding StripePublishableKey to example file

* Update publishableKey test

* Spacing

* Point-free helper

* [Payment Methods] Update padding and image view size (#581)

* Update padding and image view size

* Update stack view's spacing

* Update snapshots

* Use layoutMargins to set the padding

* [Payment methods] Disable edit button if no payment methods (#586)

* [Payment methods] Bugs & visual fixes (#578)

* Adding custom UITableViewHeader and always calling reload data on viewDidLoad

* Updating screenshots

* Cleanup autolayout warnings

* Screenshots

* PR comments

* No autolayout for footer view

* Cleanup

* Remove intrinsicContentSize

* Tableview appears without delay fix (#587)

* Fix header/footer auto sizing

* Update header background color

* Update snapshots

* Screenshots again

* Updating constraint priority to resolve ambiguity

* [Payment methods] Refresh payment methods table view properly (#588)

* Refresh payment methods table view properly

* Remove reference to weak self

* Rename delegate methods

* [Payment methods] Refetch payment methods on viewDidLoad or explicitly (by delegate) (#591)

* Do not refresh on viewWillAppear

* Use optional string to avoid unnecessary initializer

* Bring back viewWillAppear signal to better reflect view controller's lifecycle state

* [Payment methods] A11y - Credit card name (#593)

* Add card name to the a11y label

* Add comment

* [Payment Methods] Design Fixes (#592)

* Design fixes

* Fresh screenshots ✨

* Remove recordMode

* Deleting stale screenshots

* Re-add accidentally deleted line

* update strings

* [Payment Methods] Support optional card type and error handling for payment methods (#596)

* Optional card type, payment methods load error

* Optional support for imageName

* Fix accessibility label

* Fix merge conflict spacing

* Swiftlint

* Implementing PR suggestions

* Fixed bug that shows wrong expiration date (#595)

* [Payment Methods] Add New Card Design Fixes (#594)

* error message present and return key to done

* removed error message banner for incomplete payment details

* new snapshots for correct insets

* [Payment methods] Optimistically disable edit button on card deletion (#589)

* Disable edit button optimistically, use stored cards in result from card deletion

* Fix issue where edit button is not re-enabled upon the failed deletion of the last card.

* Remove unnecessary .init

* Add skipRepeats() to editButtonIsEnabled signal.

* Fixing potential reference cycles (#598)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scollaco Scollaco Scollaco approved these changes

@cdolm92 cdolm92 cdolm92 approved these changes

Assignees

@cdolm92 cdolm92

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusi @Scollaco @cdolm92