Make the tests pass #585
Merged
Make the tests pass #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusi
commented
Feb 12, 2019
|
|
||
| self.viewModel.inputs.viewDidLoad() | ||
| } | ||
|
|
||
| override func viewDidLayoutSubviews() { |
There was a problem hiding this comment.
Shamefully stole this from https://useyourloaf.com/blog/variable-height-table-view-header and it seems to pass the tests 😄
|
Can you try this suggestion? Seemed to fix the tests for me 🤷♂️ |
justinswart
approved these changes
Feb 12, 2019
justinswart
added a commit
that referenced
this pull request
Feb 19, 2019
* Add SelectCurrencyViewController * Fix tests * Add tableview header * Update snapshots * Added ViewController tests * Removed recordMode line from test * Simplify layout code for header * Remove SettingsCurrencyCell * Fix snapshot tests * Remove CaseIterable conformance on SettingsAccountCellType * Use reuseIdentifier local constant * Update pragma * Update tableview instantiation * Implicit returns in lazy vars * Fix alignment * ① [Currency selection] Remove currency picker (#568) * Remove currency picker * swiftlint * Remove redundant enum case * Remove reference * Remove local var, improve function name * Set label colour * Update snapshots * Fix project file * Correctly size header/footer views * Make the tests pass (#585) * Run snapshot tests on all devices * Remove duplicate extension, use keypath setter * Fix autolayout warnings
justinswart
added a commit
that referenced
this pull request
Feb 21, 2019
* Remove currency picker * swiftlint * Add SelectCurrencyViewController * Fix tests * Update snapshots * Add tableview header * Added ViewController tests * Removed recordMode line from test * Simplify layout code for header * Add update calls * swiftlint * Add update calls * Add view model tests * Remove stray file ref * Fix tests * swiftlint * Remove redundant enum case * Fix rebase duplication * Remove reference * Remove SettingsCurrencyCell * Fix snapshot tests * Remove CaseIterable conformance on SettingsAccountCellType * Use reuseIdentifier local constant * Update pragma * Update tableview instantiation * Implicit returns in lazy vars * Fix alignment * Add SelectCurrencyViewController * Fix tests * Add tableview header * Update snapshots * Added ViewController tests * Removed recordMode line from test * Simplify layout code for header * Remove SettingsCurrencyCell * Fix snapshot tests * Remove CaseIterable conformance on SettingsAccountCellType * Use reuseIdentifier local constant * Update pragma * Update tableview instantiation * Implicit returns in lazy vars * Fix alignment * ① [Currency selection] Remove currency picker (#568) * Remove currency picker * swiftlint * Remove redundant enum case * Remove reference * Remove local var, improve function name * Set label colour * Update snapshots * Fix project file * Correctly size header/footer views * Make the tests pass (#585) * Fix merge issue * Run snapshot tests on all devices * Remove duplicate extension, use keypath setter * Fix autolayout warnings * Fix merge issue * Add weak self, fix project file * Renamed signal * Refactor view model and tests * Use more inference
justinswart
added a commit
that referenced
this pull request
Feb 22, 2019
* ① [Currency selection] Remove currency picker (#568) * Remove currency picker * swiftlint * Remove redundant enum case * Remove reference * ③ [Currency selection] Add table view again (#582) * Remove currency picker * swiftlint * Add SelectCurrencyViewController * Fix tests * Update snapshots * Remove redundant enum case * Remove reference * Remove SettingsCurrencyCell * Fix snapshot tests * Remove CaseIterable conformance on SettingsAccountCellType * Use reuseIdentifier local constant * Update pragma * Update tableview instantiation * Set nav title * Fix yet another merge issue * Fix merge * ③ [Currency selection] Add table view header (#570) * Add SelectCurrencyViewController * Fix tests * Add tableview header * Update snapshots * Added ViewController tests * Removed recordMode line from test * Simplify layout code for header * Remove SettingsCurrencyCell * Fix snapshot tests * Remove CaseIterable conformance on SettingsAccountCellType * Use reuseIdentifier local constant * Update pragma * Update tableview instantiation * Implicit returns in lazy vars * Fix alignment * ① [Currency selection] Remove currency picker (#568) * Remove currency picker * swiftlint * Remove redundant enum case * Remove reference * Remove local var, improve function name * Set label colour * Update snapshots * Fix project file * Correctly size header/footer views * Make the tests pass (#585) * Run snapshot tests on all devices * Remove duplicate extension, use keypath setter * Fix autolayout warnings * ④ [Currency selection] Add change currency api calls (#571) * Remove currency picker * swiftlint * Add SelectCurrencyViewController * Fix tests * Update snapshots * Add tableview header * Added ViewController tests * Removed recordMode line from test * Simplify layout code for header * Add update calls * swiftlint * Add update calls * Add view model tests * Remove stray file ref * Fix tests * swiftlint * Remove redundant enum case * Fix rebase duplication * Remove reference * Remove SettingsCurrencyCell * Fix snapshot tests * Remove CaseIterable conformance on SettingsAccountCellType * Use reuseIdentifier local constant * Update pragma * Update tableview instantiation * Implicit returns in lazy vars * Fix alignment * Add SelectCurrencyViewController * Fix tests * Add tableview header * Update snapshots * Added ViewController tests * Removed recordMode line from test * Simplify layout code for header * Remove SettingsCurrencyCell * Fix snapshot tests * Remove CaseIterable conformance on SettingsAccountCellType * Use reuseIdentifier local constant * Update pragma * Update tableview instantiation * Implicit returns in lazy vars * Fix alignment * ① [Currency selection] Remove currency picker (#568) * Remove currency picker * swiftlint * Remove redundant enum case * Remove reference * Remove local var, improve function name * Set label colour * Update snapshots * Fix project file * Correctly size header/footer views * Make the tests pass (#585) * Fix merge issue * Run snapshot tests on all devices * Remove duplicate extension, use keypath setter * Fix autolayout warnings * Fix merge issue * Add weak self, fix project file * Renamed signal * Refactor view model and tests * Use more inference * swiftlint * Add success banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Should make the tests pass
🤔 Why
We need failing tests .. NAAAAT
🛠 How
Please see inline comments..