① [Currency selection] Remove currency picker

[justinswart]

📲 What

Paired with @Scollaco to remove the currency picker from SettingsAccountViewController.

🤔 Why

We've decided to replace the picker behaviour with a table view that will be pushed onto the navigation stack.

🛠 How

Deleted all references to the picker.

✅ Acceptance criteria

• Project builds successfully
• Tests pass
• Currency picker is gone

🤖Related PR's for this feature

#569

[justinswart]

Change Currency Picker to new view with TableViewCells

[ifbarrera]

Tested:
- iPhone X (12.1)
- iPhone 6s Plus (11.4)
- iPhone 6s (10.3.1)

Currency picker is gone, tapping the cell does nothing, tests pass 👍

[dusi]

Looks like case SettingsCurrencyPickerCell in Nib.swift can be removed as well..

[dusi]

[UPDATED]

Also from visual perspective there are 2 questions that come into my mind:

1. Should we add disclosure indicator to the change currency cell to imply that this will push user to a different screen?
   Noticed that this has been done in ② [Currency selection] Add table view #569

2. Should we change the text color to something more subtle?
   Using green color makes the text look like a button, but since we want the whole cell to react to taps we don't explicitly need to make this look like a button (the disclosure indicator from first point should make that clear). Cc @dannyalright

(please ignore the Text label on the screenshot - it was an accident)

[dnywh]

good catch @dusi, that was actually the intended visual outcome but not described on the Trello card. See the original collection for a mockup.

@justinswart want me to make a separate card for this?

[justinswart]

@dannyalright sure - just to be clear we add a chevron disclosure icon in a later PR, but are you saying the text should not be green?

[dnywh]

that's right. It should be the default cell 'value' colour. Here's the exact screen just to be safe. All good RE chevron in later PR