This repository has been archived by the owner on Jan 29, 2023. It is now read-only.
Fix compile error for Wio Terminal #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ansonhe97 Thanks for the PR. I'll merge for the quick fix. But the best solution is to add to the Seeed-Studio ArduinoCore SAMD core a definition such as Something similar to file I added that line to Seeed-Studio ArduinoCore SAMD core Arduino.h then forget to mention. That's why I didn't get any compiler error so far. The file cencode-Imp.h was also added by typo mistake and will be deleted. Other quick fixes are adding the definition to
|
khoih-prog
added a commit
that referenced
this pull request
Nov 28, 2020
### New in v2.3.3 1. Fix compile errors for boards (nRF52, SAMD, etc.) using libraries with lib64, such as [**EthernetWebServer**](https://github.com/khoih-prog/EthernetWebServer) 2. Fix SeeedStudio **SEEED_WIO_TERMINAL** compile errors. See [**Fix compile error for Wio Terminal**](#5) 3. Add file to SeeedStudio SAMD Packages' Patches. 4. Fix compiler warnings for duplications in WS_LOG with [WiFiWebServer Library](https://github.com/khoih-prog/WiFiWebServer)
khoih-prog
added a commit
that referenced
this pull request
Nov 28, 2020
### New in v2.3.3 1. Fix compile errors for boards (nRF52, SAMD, etc.) using libraries with lib64, such as [**EthernetWebServer**](https://github.com/khoih-prog/EthernetWebServer) 2. Fix SeeedStudio **SEEED_WIO_TERMINAL** compile errors. See [**Fix compile error for Wio Terminal**](#5) 3. Add file to SeeedStudio SAMD Packages' Patches. 4. Fix compiler warnings for duplications in WS_LOG with [WiFiWebServer Library](https://github.com/khoih-prog/WiFiWebServer)
khoih-prog
added a commit
that referenced
this pull request
Nov 28, 2020
### New in v2.3.3 1. Fix compile errors for boards (nRF52, SAMD, etc.) using libraries with lib64, such as [**EthernetWebServer**](https://github.com/khoih-prog/EthernetWebServer) 2. Fix SeeedStudio **SEEED_WIO_TERMINAL** compile errors. See [**Fix compile error for Wio Terminal**](#5) 3. Add file to SeeedStudio SAMD Packages' Patches. 4. Fix compiler warnings for duplications in WS_LOG with [WiFiWebServer Library](https://github.com/khoih-prog/WiFiWebServer)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compile error for Wio Terminal due to libb64 conflicts: