Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORE_HAS_LIBB64 definition #37

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Add CORE_HAS_LIBB64 definition #37

merged 1 commit into from
Nov 30, 2020

Conversation

khoih-prog
Copy link

Add a line to Arduino.h

#define CORE_HAS_LIBB64

to avoid compiler's duplication errors

#define CORE_HAS_LIBB64
@Pillar1989
Copy link
Member

@khoih-prog what's this micro mean? How can we use it?

@khoih-prog
Copy link
Author

Sorry I didn't clarify it because I think @ansonhe97 knows it and you're in the loop

The reason was specified in PR for WebSockets_Generic Library

Fix compile error for Wio Terminal

Hi @ansonhe97

Thanks for the PR.

I'll merge for the quick fix.

But the best solution is to add to the Seeed-Studio ArduinoCore SAMD core a definition such as

#define CORE_HAS_LIBB64

Something similar to file

core_esp8266_features.h

#define CORE_HAS_LIBB64
#define CORE_HAS_BASE64_CLASS
#define CORE_HAS_CXA_GUARD
#define CORE_HAS_UMM
...

I added that line to Seeed-Studio ArduinoCore SAMD core Arduino.h then forget to mention.

That's why I didn't get any compiler error so far.

The file cencode-Imp.h was also added by typo mistake and will be deleted.

Other quick fixes are adding the definition to

  1. the sketch.
  2. platform.txt

@Pillar1989
Copy link
Member

Got it, thanks.

@Pillar1989 Pillar1989 merged commit fe314ce into Seeed-Studio:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants