Prevent bids values with leading 0s in tests #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
akhanf,
Bradley-Karat,
mcespedes99 and
myousif9
When used with `run`, the leading 0 gets stripped because run is converted into an int. This breaks tests that instantiate a datset on the filesystem and re-parse it using generate_inputs. Adds a `type` field to run in `bids_tags.json` and uses this to filter integers with leading 0s in the zip_lists strategy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 94.27% 94.28% +0.01%
==========================================
Files 55 55
Lines 2183 2188 +5
==========================================
+ Hits 2058 2063 +5
Misses 125 125 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with
run, the leading 0 gets stripped because run is converted into an int. This breaks tests that instantiate a dataset on the filesystem and re-parse it using generate_inputs. Easiest solution is to just to prevent these values entirely