Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flicker RegQC #68

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Flicker RegQC #68

merged 3 commits into from
Apr 25, 2023

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Apr 25, 2023

Proposed changes

This PR replaces the regQC png with an fmriprep like svg file that flickers between the fixed and moving image when hovered over in the web browser

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Apr 25, 2023
kaitj added 2 commits April 25, 2023 07:35
- adds fmriprep like svg output for registration qc
- update dependencies
- remove static edge png
Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- niworkflows.viz seems like a handy package.

Could you post an example of one of these SVGs somewhere for reference? Nvm, saw it on Slack

Base automatically changed from fix-gha to main April 25, 2023 15:06
@kaitj
Copy link
Collaborator Author

kaitj commented Apr 25, 2023

Looks good -- niworkflows.viz seems like a handy package.

It is indeed - I would say there is a lot of stuff in niworkflows that we could probably use so we don't have to re-invent things. It's nice that they add the css required for flickering into the svg for the registration too.

@kaitj kaitj merged commit 38182e5 into main Apr 25, 2023
@kaitj kaitj deleted the regqc-flicker branch April 25, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants