Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resources): update to latest ldml: xmlns, uset #10865

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Feb 27, 2024

  • maybe last 'techpreview' update
  • just allows xmlns, does not test the value yet
  • may want to review commit-by-commit

Unblocks: chore(developer): support xmlns on keyboard3 files 🙀 #10803
Fixes: chore(developer): rename unicodeSet to uset 🙀 #10657

For: #10803

@keymanapp-test-bot skip

- maybe last 'techpreview' update

Unblocks: chore(developer): support xmlns on keyboard3 files 🙀  #10803
Unblocks: chore(developer): rename unicodeSet to uset 🙀  #10657

For: #10803
@srl295 srl295 self-assigned this Feb 27, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the B17S2 milestone Feb 27, 2024
Comment on lines -5 to -15
<tests name="bn-more-tests">
<test name="more-key-tests">
<startContext to=""/>
<keystroke key="more"/>
<keystroke key="ṭa"/>
<check result="ট"/>
<keystroke key="more"/>
<keystroke key="ṭa"/>
<check result="টট"/>
</test>
</tests>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

captured this in the upstream CLDR ticket.

- add xmlns to schema manually

For: chore(developer): support xmlns on keyboard3 files 🙀  #10803
@srl295 srl295 marked this pull request as ready for review February 28, 2024 00:07
@srl295 srl295 marked this pull request as draft February 28, 2024 00:09
chore(developer): rename unicodeSet to uset 🙀  #10657
@srl295 srl295 changed the title chore(resources): update to latest LDML chore(resources): update to latest ldml: xmlns. ,uset Feb 28, 2024
@srl295 srl295 changed the title chore(resources): update to latest ldml: xmlns. ,uset chore(resources): update to latest ldml: xmlns, uset Feb 28, 2024
@srl295 srl295 linked an issue Feb 28, 2024 that may be closed by this pull request
@srl295 srl295 marked this pull request as ready for review February 28, 2024 00:16
@mcdurdin mcdurdin linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srl295 srl295 merged commit 563d193 into beta Feb 29, 2024
25 checks passed
@srl295 srl295 deleted the chore/common/10803-update-ldml branch February 29, 2024 14:10
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.279-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(developer): support xmlns on keyboard3 files 🙀 chore(developer): rename unicodeSet to uset 🙀
3 participants