Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(developer): rename unicodeSet to uset 🙀 #10657

Closed
srl295 opened this issue Feb 7, 2024 · 2 comments · Fixed by #10865
Closed

chore(developer): rename unicodeSet to uset 🙀 #10657

srl295 opened this issue Feb 7, 2024 · 2 comments · Fixed by #10865
Assignees
@srl295
Labels
chore developer/
Milestone
B17S2

Comments

@srl295
Copy link
Member

srl295 commented Feb 7, 2024

per https://unicode-org.atlassian.net/browse/CLDR-17366
@srl295 srl295 added this to the B17S1 milestone Feb 7, 2024
@srl295 srl295 self-assigned this Feb 7, 2024
@mcdurdin mcdurdin modified the milestones: B17S1, B17S2 Feb 7, 2024
@mcdurdin
Copy link
Member

mcdurdin commented Feb 7, 2024

Moving to B17S2. If this change goes through on the spec, then we should not continue to support unicodeSet for the handful of early adopters -- they'll just have to deal with the shifting sands of working against non-finalized spec. Doing otherwise just leads to long term pain.

@mcdurdin mcdurdin changed the title chore(developer): rename unicodeSet to uSet 🙀 chore(developer): rename unicodeSet to uset 🙀 Feb 20, 2024
@srl295 srl295 mentioned this issue Feb 21, 2024
Closed
srl295 added a commit that referenced this issue Feb 27, 2024
@srl295
chore(resources): update to latest LDML
db32e40 
- maybe last 'techpreview' update

Unblocks: chore(developer): support xmlns on keyboard3 files 🙀  #10803
Unblocks: chore(developer): rename unicodeSet to uset 🙀  #10657

For: #10803
@srl295 srl295 mentioned this issue Feb 27, 2024
Merged
srl295 added a commit that referenced this issue Feb 28, 2024
@srl295
chore(core,developer): rename unicodeSet to uset in xml
209717a 
chore(developer): rename unicodeSet to uset 🙀  #10657
srl295 added a commit that referenced this issue Feb 28, 2024
@srl295
chore(common,developer): rename unicodeSet to uset in code
9c2a73a 
Fixes: rename unicodeSet to uset 🙀  #10657
@srl295 srl295 linked a pull request Feb 28, 2024 that will close this issue
chore(resources): update to latest ldml: xmlns, uset #10865
Merged
@sentry-io Sentry.io
Copy link

sentry-io bot commented Feb 28, 2024

Sentry Issue: KEYMAN-DEVELOPER-1QX

@srl295 srl295 mentioned this issue Mar 1, 2024
Closed
@mcdurdin mcdurdin closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
chore developer/
Projects
None yet
Milestone
B17S2
Development

Successfully merging a pull request may close this issue.

chore(resources): update to latest ldml: xmlns, uset keymanapp/keyman
2 participants
@srl295 @mcdurdin