Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OutputValues to support arrays and complex objects #5440

Merged

Conversation

Malaydewangan09
Copy link
Contributor

What changes are being made and why?

This PR addresses issue #5411 where the OutputValues task was encountering errors when using arrays or objects as values. The fix involves updating the OutputValues class to use Map<String, Object> instead of Map<String, String>, allowing it to handle arrays and other complex object types.
Closes #5411

Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!
I will merge it once the CI is green, but tested locally and it works fine

@Malaydewangan09
Copy link
Contributor Author

Sure @Skraye
Thanks!

@Skraye Skraye merged commit c667fbf into kestra-io:develop Oct 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Error in outputValues when using array as values
2 participants