Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in outputValues when using array as values #5411

Closed
razuro opened this issue Oct 10, 2024 · 5 comments · Fixed by #5440
Closed

Error in outputValues when using array as values #5411

razuro opened this issue Oct 10, 2024 · 5 comments · Fixed by #5440
Assignees
Labels
bug Something isn't working

Comments

@razuro
Copy link

razuro commented Oct 10, 2024

Describe the issue

Screenshot 2024-10-10 at 23 47 25

The above yaml will produce error:

At flow: Cannot deserialize value of type `java.lang.String` from Array value (token `JsonToken.START_ARRAY`) at [Source: UNKNOWN; byte offset: #UNKNOWN] (through reference chain: io.kestra.core.models.flows.Flow["tasks"]->java.util.ArrayList[0]->io.kestra.plugin.core.output.OutputValues["values"]->java.util.HashMap["test"])

Environment

  • Kestra Version: 0.19, 0.18.8, 0.18.5, 0.17.0
  • Operating System (OS/Docker/Kubernetes): Docker
  • Java Version (if you don't run kestra in Docker):
@razuro razuro added the bug Something isn't working label Oct 10, 2024
@Malaydewangan09
Copy link
Contributor

Hey @razuro
Can I pick up this issue if it hasn't been solved yet?
Thanks!

@Skraye
Copy link
Member

Skraye commented Oct 10, 2024

Hello @Malaydewangan09 ! We want this to be fixed before the next bugfix release which is tuesday, is it okay for you ?
I can give you until Monday, however I'll take back the issue!

Let me know if you're willing to do it, I'll assign it to you !

@Malaydewangan09
Copy link
Contributor

Hey @Skraye
I can fix it by Monday. Please assign it to me.

@Malaydewangan09
Copy link
Contributor

Hey @Skraye
We need to handle this check for OutputValues tasks on the frontend and also modify the error message?
Because the sub type can only be a string for output values right?

@Skraye
Copy link
Member

Skraye commented Oct 13, 2024

Hello @Malaydewangan09
Effectively, for some reason, we decided to go with a Map<String, String>, but now I think it should have been a Map<String, Object> to allow nested maps & arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants