Documentation and fixes for IGMP/MLD snooping #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troglobit
force-pushed
the
docs-and-fixes
branch
4 times, most recently
from
c9b3fbc to
e06084c
Compare
|
Tests not passing, at all, so marking as draft while troubleshooting that. I'll give you a ping when it's ready for review. |
troglobit
force-pushed
the
docs-and-fixes
branch
3 times, most recently
from
e33f7e9 to
72c5b37
Compare
|
@wkz build and tests should now pass, with massive-parallel disabled in the CI jobs for now. |
wkz
reviewed
Apr 25, 2024
troglobit
force-pushed
the
docs-and-fixes
branch
from
72c5b37 to
a0a212d
Compare
|
Dropping fix for issue #357 since it, for some odd reason, breaks IGMP/MLD snooping. The fix has been moved to a separate branch, stable-bridge-mac, for later triage. |
For a full ChangeLog, see: - https://github.com/kernelkit/mcd/releases/tag/v2.2 - https://github.com/kernelkit/mcd/releases/tag/v2.3 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
As described in issue #396, multicast filtering on VLAN filtering bridges did not work at all. This because bridge_mcast_settings() exited when no global multicast settings were found -- a change to the YANG model made previously triggered this fauled behavior. Also, the initial IGMP/MLD versions were set to 2/1 (kernel default) instead of 3/2 (Infix default). Fixes #396 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Writable by root, readble only by wheel members, e.g. admin. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The base mac address is used by bridges in Infix. This patch adds support for extracting a base mac from the first interface "- 1", e.g., if the mac address of e1 is 08:00:20:00:00:01, the base mac will be 08:00:20:00:00:00. This works with the Infamy test framework (Qeneth) and also with the qemu script, included in this patch. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This patch adds support for overriding the default hostname generation on Qemu systems with the /sys/firmware/qemu_fw_cfg/by_name/opt/hostname file. E.g., virtual Infamy test systems using Qeneth. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Final work item for the Infix bridge MDB support epic. Fixes #334 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Ethernet ports start with 'e' Port numbers start with '1' Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Over the lifetime of Infix, so far, we've run into at least one customer issue where we had qualms about our use of the local bit causing issues with 3rd party software. In the end that was not the root cause of our problems, but we spent way too much time worrying about it. Hence this patch, which brings our virtual environments another step closer to the real hardware that Infix runs on. The OUI used is one of the "private" ones, taken completly at random. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The massive-parallel build change added recently is a bit shaky still, so while we stabilze that, we revert it and also take the oppportunity to tag the new build server. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
docs-and-fixes
branch
from
a0a212d to
1f32e23
Compare
|
Finally, tests now pass. Could you lend an eye for final review, @wkz so we can merge this puppy? |
!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR primarily deals with fixes for IGMP/MLD snooping and bridge set up, as well as documentation of said feature, which is a new feature for Infix v24.04.
Other changes also included here:
Fix "random IPv6 autoconf" address, caused by random MAC address on bridgesBridges now use the base MAC address by defaultOverriding bridge MAC address usingphys-addresshostnamefrom/sys/firmware/qemu_fw_cfg(for Infamy and other Qemu based systems)ethN -> eN, also changing start index from 0 to 1test/qenethsubmodule to support new Infamy port namesChecklist
Tick relevant boxes, this PR is-a or has-a: