Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge: per-VLAN default multicast settings are off #396

Closed
troglobit opened this issue Apr 15, 2024 · 0 comments
Closed

bridge: per-VLAN default multicast settings are off #396

troglobit opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@troglobit
Copy link
Contributor

troglobit commented Apr 15, 2024

The global bridge setting mcast_vlan_snooping VAL must be set to 1 on VLAN filtering bridges when a given VLAN has multicast filtering enabled.

Also, the default IGMP and MLD versions on a new VLAN filtering bridge are off:

admin@example:~$ bridge vlan global show dev br1
port              vlan-id  
br1               1-2
                    mcast_snooping 1 mcast_querier 0 mcast_igmp_version 2 mcast_mld_version 1 mcast_last_member_count 2 mcast_last_member_interval 100 mcast_startup_query_count 2 mcast_startup_query_interval 3124 mcast_membership_interval 26000 mcast_querier_interval 25500 mcast_query_interval 12500 mcast_query_response_interval 1000 
admin@example:~$ bridge -j vlan global show dev br1
[{"ifname":"br1","vlans":[{"vlan":1,"vlanEnd":2,"mcast_snooping":1,"mcast_querier":0,"mcast_igmp_version":2,"mcast_mld_version":1,"mcast_last_member_count":2,"mcast_last_member_interval":100,"mcast_startup_query_count":2,"mcast_startup_query_interval":3124,"mcast_membership_interval":26000,"mcast_querier_interval":25500,"mcast_query_interval":12500,"mcast_query_response_interval":1000}]}]
admin@example:~$ bridge -j vlan global show dev br1 |jq
[
  {
    "ifname": "br1",
    "vlans": [
      {
        "vlan": 1,
        "vlanEnd": 2,
        "mcast_snooping": 1,
        "mcast_querier": 0,
        "mcast_igmp_version": 2,
        "mcast_mld_version": 1,
        "mcast_last_member_count": 2,
        "mcast_last_member_interval": 100,
        "mcast_startup_query_count": 2,
        "mcast_startup_query_interval": 3124,
        "mcast_membership_interval": 26000,
        "mcast_querier_interval": 25500,
        "mcast_query_interval": 12500,
        "mcast_query_response_interval": 1000
      }
    ]
  }
]
  • IGMP version should be 3
  • MLD version should be 2
@troglobit troglobit self-assigned this Apr 15, 2024
@troglobit troglobit converted this from a draft issue Apr 15, 2024
@troglobit troglobit moved this to Todo in Infix & C:o Apr 15, 2024
@troglobit troglobit added this to the Infix v24.04 milestone Apr 15, 2024
@troglobit troglobit changed the title bridge: per-VLAN default multicast settings off bridge: per-VLAN default multicast settings are off Apr 21, 2024
@troglobit troglobit moved this from Todo to In progress in Infix & C:o Apr 21, 2024
troglobit added a commit that referenced this issue Apr 21, 2024
As described in issue #396, multicast filtering on VLAN filtering
bridges did not work at all.  This because bridge_mcast_settings()
exited when no global multicast settings were found -- a change to
the YANG model made previously triggered this fauled behavior.

Also, the initial IGMP/MLD versions were set to 2/1 (kernel default)
instead of 3/2 (Infix default).

Fixes #396

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit added the bug Something isn't working label Apr 21, 2024
troglobit added a commit that referenced this issue Apr 23, 2024
As described in issue #396, multicast filtering on VLAN filtering
bridges did not work at all.  This because bridge_mcast_settings()
exited when no global multicast settings were found -- a change to
the YANG model made previously triggered this fauled behavior.

Also, the initial IGMP/MLD versions were set to 2/1 (kernel default)
instead of 3/2 (Infix default).

Fixes #396

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit pinned this issue Apr 24, 2024
@troglobit troglobit unpinned this issue Apr 24, 2024
troglobit added a commit that referenced this issue Apr 25, 2024
As described in issue #396, multicast filtering on VLAN filtering
bridges did not work at all.  This because bridge_mcast_settings()
exited when no global multicast settings were found -- a change to
the YANG model made previously triggered this fauled behavior.

Also, the initial IGMP/MLD versions were set to 2/1 (kernel default)
instead of 3/2 (Infix default).

Fixes #396

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Apr 25, 2024
As described in issue #396, multicast filtering on VLAN filtering
bridges did not work at all.  This because bridge_mcast_settings()
exited when no global multicast settings were found -- a change to
the YANG model made previously triggered this fauled behavior.

Also, the initial IGMP/MLD versions were set to 2/1 (kernel default)
instead of 3/2 (Infix default).

Fixes #396

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit added a commit that referenced this issue Apr 28, 2024
As described in issue #396, multicast filtering on VLAN filtering
bridges did not work at all.  This because bridge_mcast_settings()
exited when no global multicast settings were found -- a change to
the YANG model made previously triggered this fauled behavior.

Also, the initial IGMP/MLD versions were set to 2/1 (kernel default)
instead of 3/2 (Infix default).

Fixes #396

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@wkz wkz closed this as completed in e59bab1 Apr 29, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infix & C:o Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant