Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

Ensure onToggle is called when on is controlled but setOnState is called #18

Merged
merged 3 commits into from
Mar 24, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/__tests__/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,25 @@ test('onToggle gets called in controlled prop scenario', () => {
expect(spy).not.toHaveBeenCalled()
wrapper.setProps({on: true})
expect(spy).toHaveBeenCalled()
expect(spy.mock.calls.length).toBe(1)
})

test('onToggle gets called with fresh state in controlled prop scenario', () => {
const spy = jest.fn()
const {wrapper} = setup({on: false, onToggle: spy})
wrapper.setProps({on: true})
expect(spy).toHaveBeenLastCalledWith(true, expect.anything())
expect(spy.mock.calls.length).toBe(1)
})

test('onToggle gets called when setOnState is called in controlled prop scenario', () => {
const spy = jest.fn()
const {getTogglerProps} = setup({on: false, onToggle: spy})
const {onClick} = getTogglerProps()
const fakeEvent = {target: null}
onClick(fakeEvent)
expect(spy).toHaveBeenLastCalledWith(true, expect.anything())
expect(spy.mock.calls.length).toBe(1)
})

function setup({children = () => <div />, ...props} = {}) {
Expand Down
3 changes: 3 additions & 0 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ class Toggle extends Component {
}

setOnState = (state = !this.getOn()) => {
if (this.getOn() !== state) {
this.props.onToggle(state, this.getTogglerStateAndHelpers())
}
this.setState({on: state})
}

Expand Down