Ensure onToggle is called when on is controlled but setOnState is called

[bslinger]

What: Fix a bug introduced in #17 that prevents onToggle from being called when the internal setOnState is called.

Why: When on is controlled, onToggle should be called either when the controlled prop is change, or when the internal toggle actually occurs

How: I added a check in setOnState to compare the current on with the new state and call onToggle if necessary.

Checklist:

• Documentation N/A
• Tests
• Ready to be merged
• Added myself to contributors table

[kentcdodds]

This looks good to me. Thanks!

[kentcdodds]

Looks like we need another test to get our code coverage goal. Could you please do that?

[bslinger]

Ah, just noticed that. Strange, shouldn't line 72 be covered since setOnState is being called in several tests? Sorry, I'm not as familiar with jest as I'd like to be!

[kentcdodds]

If you want to look at the coverage report, open coverage/lcov-report/index.html locally in your browser 👍 that could help.

[codecov]

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          18     20    +2     
  Branches        7      8    +1     
=====================================
+ Hits           18     20    +2

Impacted Files	Coverage Δ
src/index.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa7805...5299b74. Read the comment docs.

[bslinger]

Ah thanks, I see, I had to make sure both branches of the if were covered - looks like this did the trick!

[kentcdodds]

Sweet! Thanks!