-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add check for overwrite readme #143
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
const inquirer = require('inquirer') | ||
|
||
const question = { | ||
type: 'list', | ||
message: | ||
'⚠ Readme-md-generator will overwrite your current README.md. Are you sure you want to continue? ', | ||
name: 'overwriteReadme', | ||
choices: [ | ||
{ | ||
name: 'No', | ||
value: false | ||
}, | ||
{ | ||
name: 'Yes ', | ||
value: true | ||
} | ||
] | ||
} | ||
|
||
/** | ||
* Ask user if he wants overwrite the existed README | ||
*/ | ||
module.exports = async () => { | ||
const { overwriteReadme } = await inquirer.prompt([question]) | ||
return overwriteReadme | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,44 @@ | ||||||
const inquirer = require('inquirer') | ||||||
|
||||||
const askOverwrite = require('./ask-overwrite') | ||||||
|
||||||
const expectedQuestion = { | ||||||
type: 'list', | ||||||
message: | ||||||
'⚠ Readme-md-generator will overwrite your current README.md. Are you sure you want to continue? ', | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
name: 'overwriteReadme', | ||||||
choices: [ | ||||||
{ | ||||||
name: 'No', | ||||||
value: false | ||||||
}, | ||||||
{ | ||||||
name: 'Yes ', | ||||||
value: true | ||||||
} | ||||||
] | ||||||
} | ||||||
|
||||||
inquirer.prompt = jest.fn(items => | ||||||
Promise.resolve( | ||||||
items.reduce((result, item) => { | ||||||
result[item.name] = 'value' | ||||||
return result | ||||||
}, {}) | ||||||
) | ||||||
) | ||||||
|
||||||
describe('ask-overwrite', () => { | ||||||
beforeEach(() => { | ||||||
inquirer.prompt.mockClear() | ||||||
}) | ||||||
|
||||||
it('should call prompt right questions', async () => { | ||||||
await askOverwrite() | ||||||
expect(inquirer.prompt).toHaveBeenCalledWith([expectedQuestion]) | ||||||
}) | ||||||
|
||||||
it('should return the right value', async () => { | ||||||
expect(await askOverwrite()).toEqual('value') | ||||||
}) | ||||||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -5,15 +5,17 @@ const askQuestions = require('./ask-questions') | |||||||
|
||||||||
/** | ||||||||
* Main process: | ||||||||
* 1) Get README template path | ||||||||
* 2) Gather project infos | ||||||||
* 3) Ask user questions | ||||||||
* 4) Build README content | ||||||||
* 5) Create README.md file | ||||||||
* 1) Check overwrite README.md | ||||||||
* 2) Get README template path | ||||||||
* 3) Gather project infos | ||||||||
* 4) Ask user questions | ||||||||
* 5) Build README content | ||||||||
* 6) Create README.md file | ||||||||
* | ||||||||
* @param {Object} args | ||||||||
*/ | ||||||||
module.exports = async ({ customTemplatePath, useDefaultAnswers }) => { | ||||||||
if (!(await readme.checkOverwriteReadme())) return | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
const templatePath = await readme.getReadmeTemplatePath( | ||||||||
customTemplatePath, | ||||||||
useDefaultAnswers | ||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.