✨ Add check for overwrite readme #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kefranabg , there is no unit test yet, but I would be glad to have your opinion about my implementation. I'll do tests if you are agree with it. |
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 24 25 +1
Lines 197 206 +9
Branches 21 23 +2
=====================================
+ Hits 197 206 +9
Continue to review full report at Codecov.
|
Add check for overwrite readme #140
|
Implem looks good to me, I think you can go ahead! I'll do a full review ASAP |
|
Done ! I added tests. |
kefranabg
reviewed
Oct 4, 2019
src/ask-overwrite.js
Outdated
| const question = { | ||
| type: 'list', | ||
| message: | ||
| '⚠ Readme-md-generator will overwrite your current README.md. Are you sure you want to continue? ', |
There was a problem hiding this comment.
Suggested change
| '⚠ Readme-md-generator will overwrite your current README.md. Are you sure you want to continue? ', | |
| '⚠ readme-md-generator will overwrite your current README file. Are you sure you want to continue? ', |
src/ask-overwrite.spec.js
Outdated
| const expectedQuestion = { | ||
| type: 'list', | ||
| message: | ||
| '⚠ Readme-md-generator will overwrite your current README.md. Are you sure you want to continue? ', |
There was a problem hiding this comment.
Suggested change
| '⚠ Readme-md-generator will overwrite your current README.md. Are you sure you want to continue? ', | |
| '⚠ readme-md-generator will overwrite your current README file. Are you sure you want to continue? ', |
| * | ||
| * @param {Object} args | ||
| */ | ||
| module.exports = async ({ customTemplatePath, useDefaultAnswers }) => { | ||
| if (!(await readme.checkOverwriteReadme())) return |
There was a problem hiding this comment.
Suggested change
| if (!(await readme.checkOverwriteReadme())) return | |
| if (!(await readme.checkOverwriteReadme())) return | |
|
Thanks buddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for overwrite readme #140