Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Genesis hash is only consistent upon using the raw chainspec file #1498

Merged
merged 19 commits into from
Apr 4, 2024
Merged

Genesis hash is only consistent upon using the raw chainspec file #1498

merged 19 commits into from
Apr 4, 2024

Conversation

hhamud
Copy link
Contributor

@hhamud hhamud commented Mar 5, 2024 •
edited
Loading

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix

What is the current behavior?

See #1485

What is the new behavior?

Genesis Hash does not change upon every new instance of node created.

Does this introduce a breaking change?

No

Other information

@hhamud hhamud mentioned this pull request Mar 6, 2024
Merged
@hhamud hhamud marked this pull request as ready for review March 29, 2024 20:55
EvolveArt and others added 5 commits March 29, 2024 22:21
@EvolveArt @tdelabro @hhamud
✨ add state_diff to trace API (keep-starknet-strange#1390)
95adb6c 
Co-authored-by: Timothée Delabrouille <34384633+tdelabro@users.noreply.github.com>
@anondev1993 @hhamud
refacto: clean trace api (keep-starknet-strange#1483)
8585252
@SamrendraS @apoorvsadana
@EvolveArt @tdelabro @anondev1993 @hhamud
Build Breakage with Avail and Celestia Feature Flags (Madara PR keep…
157e33f 
…-starknet-strange#1481) (keep-starknet-strange#1487)

Co-authored-by: apoorvsadana <95699312+apoorvsadana@users.noreply.github.com>
Co-authored-by: 0xevolve <Artevolve@yahoo.com>
Co-authored-by: Timothée Delabrouille <34384633+tdelabro@users.noreply.github.com>
Co-authored-by: anondev1993 <114292591+anondev1993@users.noreply.github.com>
@greged93 @anondev1993 @hhamud
opti: use vec::with_capacity when possible (keep-starknet-strange#1535
2aa30d6 
)

Co-authored-by: anondev1993 <kycbored@gmail.com>
@hhamud
creating a local testnet with multiple nodes fails using only flags (k…
518e7f4 
…eep-starknet-strange#1482)
@hhamud
Copy link
Contributor Author

hhamud commented Mar 30, 2024

@tdelabro can you review this?

@EvolveArt
Copy link
Collaborator

We should probably investigate zombienet tho to make this more resilient and easily test with different numbers of validators/peers
cc https://github.com/paritytech/subxt/tree/master/examples/parachain-example

@hhamud
Copy link
Contributor Author

hhamud commented Apr 3, 2024

We should probably investigate zombienet tho to make this more resilient and easily test with different numbers of validators/peers cc https://github.com/paritytech/subxt/tree/master/examples/parachain-example

I'll keep this in mind if the problem re-surfaces again. Also will that tool also help with this? #1254

@hhamud hhamud requested a review from apoorvsadana April 3, 2024 17:55
@EvolveArt
Copy link
Collaborator

We should probably investigate zombienet tho to make this more resilient and easily test with different numbers of validators/peers cc https://github.com/paritytech/subxt/tree/master/examples/parachain-example

I'll keep this in mind if the problem re-surfaces again. Also will that tool also help with this? #1254

Not really no its only for local testing

@EvolveArt EvolveArt merged commit c397c90 into keep-starknet-strange:main Apr 4, 2024
13 of 14 checks passed
@hhamud hhamud mentioned this pull request Apr 4, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EvolveArt EvolveArt EvolveArt approved these changes

@apoorvsadana apoorvsadana Awaiting requested review from apoorvsadana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hhamud @EvolveArt @apoorvsadana @anondev1993 @SamrendraS @greged93