Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

creating a local testnet with multiple nodes fails using only flags #1482

Merged
merged 16 commits into from
Mar 26, 2024

Conversation

hhamud
Copy link
Contributor

@hhamud hhamud commented Feb 28, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix

What is the current behavior?

Current behaviour is that genesis configuration hash changes upon each node instance. Therefore it is not possible to build a local testnet with multiple notes using only the cli flags.

I am not sure why the chainspec is not deterministic, could it be the wasm runtime?.

Resolves: #NA

What is the new behavior?

New behaviour is that it is possible to create a local testnet with multiple nodes using only cli flags as it just spits out the chainspec configuration into a json file and uses the same one.

Does this introduce a breaking change?

No

Other information

@hhamud hhamud marked this pull request as ready for review February 29, 2024 14:26
Copy link
Collaborator

@apoorvsadana apoorvsadana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, you mean writing it to a JSON file and reading it back makes it work fine? can you debug the differences between in the spec in both the cases, this seems to be a hacky solution for now but its definitely progress and has some insights

scripts/run_testnet.sh Show resolved Hide resolved
scripts/run_testnet.sh Outdated Show resolved Hide resolved
@hhamud
Copy link
Contributor Author

hhamud commented Mar 5, 2024

@apoorvsadana @tdelabro can we merge this?

@tdelabro tdelabro added the Fix label Mar 5, 2024
scripts/run_testnet.sh Show resolved Hide resolved
crates/node/src/command.rs Show resolved Hide resolved
@hhamud
Copy link
Contributor Author

hhamud commented Mar 20, 2024

@tdelabro can you check this?

@tdelabro tdelabro merged commit 943f323 into keep-starknet-strange:main Mar 26, 2024
12 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: creating a local testnet with multiple nodes fails using only flags
3 participants