This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Inter-medi[anizer]-ary: Add intermediary authorized medianizer access contract for Ropsten #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowfiend
force-pushed
the
inter-medianizer-ary
branch
from
759e041 to
a3dd6b4
Compare
| return _realMedianizer; | ||
| } | ||
|
|
||
| function read() external view returns (uint256) { |
There was a problem hiding this comment.
we use the peek function too, in order to check if the medialized is active
There was a problem hiding this comment.
Well crap. That's going to require a new deployment. Wish we could just try/catch, but I guess that's for the land of Solidity 0.6.
There was a problem hiding this comment.
Amended this as part of the rebase.
Shadowfiend
force-pushed
the
inter-medianizer-ary
branch
from
a3dd6b4 to
4cd0999
Compare
Shadowfiend
force-pushed
the
inter-medianizer-ary
branch
2 times, most recently
from
7f3b274 to
628ccbb
Compare
| @@ -5,12 +5,12 @@ pragma solidity 0.5.17; | |||
| interface IMedianizer { | |||
| /// @notice Get the current price. | |||
| /// @dev May revert if caller not whitelisted. | |||
| /// @return Price (USD) with 18 decimal places. | |||
| /// @return Designated price with 18 decimal places. | |||
| function read() external view returns (uint256); | |||
|
|
|||
| /// @notice Get the current price and check if the price feed is active | |||
| /// @dev May revert if caller not whitelisted. | |||
| /// @return Price (USD) with 18 decimal places. | |||
There was a problem hiding this comment.
Price (USD) -> Designated price like above?
with 18 decimal places is tris true for all maker medianizers?
There was a problem hiding this comment.
It appears to be true for all of them, yes.
Shadowfiend
force-pushed
the
inter-medianizer-ary
branch
from
628ccbb to
c187144
Compare
In preparation for an ETHBTC feed.
Shadowfiend
force-pushed
the
inter-medianizer-ary
branch
from
c187144 to
0677d2b
Compare
So that new system deployments don't require new contract authorizations on the Maker side, an intermediate medianizer has already been deployed to Ropsten for Maker to authorize. It is designed to have an updatable reference to the Maker medianizer, and pass through reads to that instance. The already-deployed address is added to the externals file, while the code is checked in to the price-feed directory, but not migrated as part of the system migrations.
Shadowfiend
force-pushed
the
inter-medianizer-ary
branch
from
0677d2b to
2f5a57c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that new system deployments don't require new contract authorizations
on the Maker side, an intermediate medianizer has already been deployed
to Ropsten for Maker to authorize. It is designed to have an updatable
reference to the Maker medianizer, and pass through reads to that
instance.
The already-deployed address is added to the externals file, while the
code is checked in to the price-feed directory, but not migrated as part
of the system migrations.
Still needed here:
Merging Price feed governable addition #545Rebase onto Price feed governable addition #545.Rebasing this against the resultingmasterand aligning externals hookup.