This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Price feed governable addition #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 31, 2020 22:09
Peek allows us to query the Medianizer wihtout reverting. This will be useful if we just want to check if the price feed is live
BTCETHPriceFeed Should implement the functions needed to add price feeds in case one breaks.
Instead of holding one pair of feeds, hold an array of feeds for each (btcUsdFeeds and ethUsdFeeds) When calculating price, look for the first active price feed from each array and use that one for to get the corresponding asset price. Only `TBTCSystem` is allowed to add a new Medianizer feed
peek does not revert on zero-value feed querry, therefore it is useful for checking Medianizer status without reprocusions.
the addition is two-step just like all the other governable values. eg: initializeAddBtcUsdFeed is called, and after `priceFeedGovernanceTimeDelay` has passed finalizeAddBtcUsdFeed can be called Events are emitted during every step of the process.
btcEthPriceFeed.initialize() now takes TBTCSystem address for ACL
NicholasDotSol
force-pushed
the
price-feed-gov
branch
from
1eb03dd to
2bf21ee
Compare
Shadowfiend
reviewed
Apr 4, 2020
| IMedianizer btcPriceFeed; | ||
| IMedianizer ethPriceFeed; | ||
| IMedianizer[] private btcUsdFeeds; | ||
| IMedianizer[] private ethUsdFeeds; |
There was a problem hiding this comment.
Really it's two changes here… We'll have a single direct BTCETH price feed, in addition to this way of dealing with failures.
mhluongo
previously requested changes
Apr 5, 2020
| IMedianizer btcPriceFeed; | ||
| IMedianizer ethPriceFeed; | ||
| IMedianizer[] private btcUsdFeeds; | ||
| IMedianizer[] private ethUsdFeeds; |
|
added 3 commits
April 7, 2020 06:02
Instead pf using BTCUSD and ETHUSD medianizers, use a direct BTCETH medianizer
Shadowfiend
reviewed
Apr 8, 2020
Merged
1 task
Use the finaince definition pair, where ETHBTC represents the number of BTC in an ETH. This is what the input is. As a price feed output, we use saewei, meaning the number of wei in a satoshi. We will use satwei to clculate lot size value
In preparation for an ETHBTC feed.
So that new system deployments don't require new contract authorizations on the Maker side, an intermediate medianizer has already been deployed to Ropsten for Maker to authorize. It is designed to have an updatable reference to the Maker medianizer, and pass through reads to that instance. The already-deployed address is added to the externals file, while the code is checked in to the price-feed directory, but not migrated as part of the system migrations.
Inter-medi[anizer]-ary: Add intermediary authorized medianizer access contract for Ropsten
Something got mangled somewhere along the way...
Shadowfiend
suggested changes
Apr 15, 2020
Shadowfiend
reviewed
Apr 15, 2020
The new intermediary medianizer incorporates the peek() method.
Ensure the correct unsits are used and add missing docs
|
Can we get an updated / accurate PR description before merge? Dismissing my review for now, happy to take a second look when ready |
|
Description is accurate already as far as I can tell. |
added 3 commits
April 16, 2020 10:36
…into price-feed-gov
Clarify that `SatWeiPriceFeed` utilizes a price feed operated by MakerDao, not that it is operated by MkerDao itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of holding two feeds, ETH/USD and BTC/USD, hold an array
of direct
ETH/BTCfeeds.When calculating price, look for the first active price feed from the
ETH/BTCarray and use that one to calculate the wei/sat price. Thenuse this to calculate lot size in wei where needed.
Feeds can only be added to this array by
TBTCSystem;TBTCSystemhas a 90-day timer before a price feed addition can be finalized.
Also includes #576 .