Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Use specific contract types #542

Merged
merged 13 commits into from
Mar 26, 2020
Merged

Use specific contract types #542

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1f5c278
Use TBTCDepositToken instead of address
Mar 25, 2020
3e6b63a
Use contract over addresses types where reasonable
Mar 25, 2020
3303dc5
TBTCSystem address-> contract type where reasonable
Mar 25, 2020
2577752
Use contract types direclty in parameters
Mar 25, 2020
54b1567
Update ITBTCSystem interface
Mar 25, 2020
9878ca5
Use ITBTCSystem directly from DepositUtils
Mar 25, 2020
ef8c467
Make contract types public
Mar 25, 2020
41104d0
Contract type for Function parameters
Mar 25, 2020
fc03c4f
Avoid unnecessary double-case
Mar 26, 2020
9f31086
distributeERC20Reward takes IERC20
Mar 26, 2020
08bba81
vendingMachine -> vendingMachineAddress
Mar 26, 2020
38e0b59
Update capitalization for consistency
Mar 26, 2020
6756361
Under distributeERC20Reward Interface change
Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions solidity/contracts/interfaces/ITBTCSystem.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,10 @@ interface ITBTCSystem {
function fetchRelayPreviousDifficulty() external view returns (uint256);

function getInitialCollateralizedPercent() external view returns (uint128);
function getAllowNewDeposits() external view returns (bool);
function isAllowedLotSize(uint256 _lotSizeSatoshis) external view returns (bool);
function requestNewKeep(uint256 _m, uint256 _n, uint256 _bond) external payable returns (address);
function getSignerFeeDivisor() external view returns (uint256);
function getUndercollateralizedThresholdPercent() external view returns (uint128);
function getSeverelyUndercollateralizedThresholdPercent() external view returns (uint128);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably our docs should be here rather than on TBTCSystem, but I need to see how our documentation generator is operating.

}