Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Use specific contract types #542

Merged
merged 13 commits into from
Mar 26, 2020
Merged

Use specific contract types #542

merged 13 commits into from
Mar 26, 2020

Commits on Mar 25, 2020

  1. Use TBTCDepositToken instead of address 

    Only TBTCDepositToken should be changed since it is the only
contract used.
The rest are just address placeholders for init funcitons.
    NicholasDotSol committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    1f5c278 View commit details
    Browse the repository at this point in the history

  2. Use contract over addresses types where reasonable 

    FeeRebateToken not using IERC721 since the interface does
not expose an exists() function
    NicholasDotSol committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3e6b63a View commit details
    Browse the repository at this point in the history

  3. TBTCSystem address-> contract type where reasonable

    NicholasDotSol committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3303dc5 View commit details
    Browse the repository at this point in the history

  4. Use contract types direclty in parameters 

    Instead of casting the parameter adress, accept Contract type directly
    NicholasDotSol committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    2577752 View commit details
    Browse the repository at this point in the history

  5. Update ITBTCSystem interface 

    Add functions needed to create a new Deposit.
    NicholasDotSol committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    54b1567 View commit details
    Browse the repository at this point in the history

  6. Use ITBTCSystem directly from DepositUtils 

    The interface should contain all function sneeded to
create the Deposit.
    NicholasDotSol committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    9878ca5 View commit details
    Browse the repository at this point in the history

  7. Make contract types public 

    Explicit visibility for consistency
    NicholasDotSol committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    ef8c467 View commit details
    Browse the repository at this point in the history

  8. Contract type for Function parameters 

    When a contract has use beyon it's address,
Pass the contract type isntead of the address.
    NicholasDotSol committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    41104d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Avoid unnecessary double-case 

    Use `this` instead of casting twice to get to the same result.
    NicholasDotSol committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    fc03c4f View commit details
    Browse the repository at this point in the history

  2. distributeERC20Reward takes IERC20 

    Take an explicit contract type over an address
    NicholasDotSol committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    9f31086 View commit details
    Browse the repository at this point in the history

  3. vendingMachine -> vendingMachineAddress 

    We're not using the contract instance, clarify that
we are only using the address
    NicholasDotSol committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    08bba81 View commit details
    Browse the repository at this point in the history

  4. Update capitalization for consistency

    NicholasDotSol committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    38e0b59 View commit details
    Browse the repository at this point in the history

  5. Under distributeERC20Reward Interface change 

    Changing distributeERC20Reward to accept IERC20 param
Requires some dependency syncing

Revert the change for now
    NicholasDotSol committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    6756361 View commit details
    Browse the repository at this point in the history