This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Block liquidationInitiator fallback revert on purchaseSignerBondsAtAuction #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send does not raise a revert, so if ether is sent to a reverting fallback the system won't halt.
Transfering the contract balance prevents a 1-wei remainder from being left behind.
Shadowfiend
approved these changes
Mar 16, 2020
| } else { | ||
| // There will always be a liquidation initiator. | ||
| uint256 split = contractEthBalance.div(2); | ||
| _d.pushFundsToKeepGroup(split); | ||
| initiator.transfer(split); | ||
| /* solium-disable-next-line security/no-send */ | ||
| initiator.send(address(this).balance); |
There was a problem hiding this comment.
No loss of functionality here so I'm good, but a couple of questions:
- Do we want to leave space for the initiator to pull their funds manually in case this fails? This could use a raw
.call()since the initiator would be paying for their withdrawal. - Do we want to globally disable the security/no-send rule?
No need for further action here until we figure out how we want to tackle the inherent issues with the initiator split, though.
There was a problem hiding this comment.
As @Shadowfiend noted, the method could also bit split in to parts: (1) first part liquidating the deposit and pushing funds to keep (secure) (2) a method that allows the initiator to pull the deposit contracts balance. this would avoid a case where eth is locked in the contract because send fails (which should be unlikely).
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #503, #504
Senddoes not raise a revert, so if ether is sentto a reverting fallback the system won't halt.
the remainder of the contract balance is cent after the first half to avoid a 1-wei remainder on odd initial balances.