Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

liquidationInitiator fallback revert can block purchaseSignerBondsAtAuction #503

Closed
1 task done
NicholasDotSol opened this issue Mar 3, 2020 · 0 comments · Fixed by #524
Closed
1 task done
Labels

Comments

@NicholasDotSol
Copy link
Contributor

NicholasDotSol commented Mar 3, 2020

during purchaseSignerBondsAtAuction, Instead of receiving a share of the funds the liquidationInitiator can decide to intentionally reject the funds by raising an exception causing initiator.transfer(contractEthBalance) to throw, blocking the auction and forcing the liquidation to fail. The deposit will stay in one of the *_liquidation_in_progress states.

  • use address.send instead instead of address.transfer
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant