Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update github handler #741

Merged
merged 3 commits into from
Sep 28, 2023
Merged

update github handler #741

merged 3 commits into from
Sep 28, 2023

Conversation

bard
Copy link
Contributor

@bard bard commented Sep 2, 2023 •
edited
Loading

fixes #713

docs change: #741

related: #728

This was referenced Sep 2, 2023
Merged
Closed
@bard bard force-pushed the fix-update-github-webhook-handler branch from fc68cae to 6c9f9a0 Compare September 2, 2023 10:25
joebowbeer
joebowbeer approved these changes Sep 2, 2023
View reviewed changes
Copy link
Collaborator

@joebowbeer joebowbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just wondering, considering Packages works and (per Github) is the preferred approach, is there an upside to maintaining the docker registry event?

I have no idea.

@rusenask rusenask merged commit f4415cb into keel-hq:master Sep 28, 2023
@brianmay brianmay mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joebowbeer joebowbeer joebowbeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github webhooks integration is broken
3 participants
@bard @joebowbeer @rusenask