Github webhooks integration is broken

[calvinli723]

When I use the "registry package" payload on github, I get:

"registry package type was not docker"

as response.

Also, when I use the "package" payload on github, nothing seems to happen. The code in pkg/http/github_webhook_trigger.go has a line looking for "package_v2" as event type for the payload, which I believe is just "package" now.

[joebowbeer]

Yes, the event type is just package now

https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#package

See also: google/go-github#2033

[bard]

Took a stab at this in #741 — works for me but one test is failing.

Note you need to change webhook config in your repository so that "Packages" events are sent rather of "Registry Packages" (docs change at keel-hq/keel.sh#50)

[bard]

Also, if anyone wants to test it, it's temporarily available at ghcr.io/bard/keel:master

[joebowbeer]

@bard I think the failing unit test is still sending the "package_v2" header

keel/pkg/http/github_webhook_trigger_test.go

Line 383 in 3ecd57c

req.Header.Set("X-GitHub-Event", "package_v2")

Whereas you changed the expected header to "package"

keel/pkg/http/github_webhook_trigger.go

Line 72 in 6c9f9a0

case "package":