ScaledObject.Status update should handle stale resource #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmelsayed
reviewed
Jan 29, 2020
ahmelsayed
approved these changes
Jan 29, 2020
zroubalik
force-pushed
the
scaledStatus
branch
from
0daa524
to
7420bef
Compare
Fixed, thx |
ahmelsayed
changed the title
melmaliacone
pushed a commit
to melmaliacone/keda
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ScaledObject changes like editing or adding a label don't change generation, therefore the resource will become stale, if we try to update it's Status in the ScaleLoop.
This adds a check on this particullar situation and try to re-fetch the ScaledObject if necessary.
Fixes #512