Doesn't reconcile on ScaledObject updates that don't change generation

[zroubalik]

if the ScaledObject changes, like editing or adding a label, this don't change generation therefore the resource version will become stale and non-recoverable.

keda-operator-697b98dcdd-2zx98 keda-operator {"level":"error","ts":1575994775.0837214,"logger":"scalehandler","msg":"Error updating scaledObject status","ScaledObject.Namespace":"default","ScaledObject.Name":"rabbitmq-consumer","ScaledObject.ScaleType":"deployment","error":"Operation cannot be fulfilled on scaledobjects.keda.k8s.io \"rabbitmq-consumer\": the object has been modified; please apply your changes to the latest version and try again","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/zapr@v0.1.1/zapr.go:128\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).updateScaledObjectStatus\n\tkeda/pkg/handler/scale_handler.go:47\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).scaleDeployment\n\tkeda/pkg/handler/scale_deployments.go:35\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).handleScaleDeployment\n\tkeda/pkg/handler/scale_loop.go:130\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).handleScale\n\tkeda/pkg/handler/scale_loop.go:45\ngithub.com/kedacore/keda/pkg/handler.(*ScaleHandler).HandleScaleLoop\n\tkeda/pkg/handler/scale_loop.go:28"}

Expected Behavior

Reconcile on ScaledObject update that that don't change generation

Actual Behavior

Doesnt' reconcile on ScaledObject update that that don't change generation

Steps to Reproduce the Problem

Change label on ScaledObject and save.

Specifications

• Version: 1.0.0