Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed 'disableScaleToZero' attribute from Prometheus scaled ob… #392

Merged
merged 1 commit into from
Oct 31, 2019
Merged

removed 'disableScaleToZero' attribute from Prometheus scaled ob… #392

merged 1 commit into from
Oct 31, 2019

Conversation

abhirockzz
Copy link
Contributor

fixes #381

@tomkerkhove
Copy link
Member

tomkerkhove commented Oct 23, 2019 •
edited
Loading

@balchua You've mentioned that minreplicas=1 defined is sufficient.

What are you referring to exactly?

@abhirockzz
Copy link
Contributor Author

@tomkerkhove what it means is that minReplicaCount in the spec is used to define the minimum number of Pods and disableScaleToZero is not required

@tomkerkhove
Copy link
Member

Oh I see, thanks.

@balchua
Copy link
Contributor

balchua commented Oct 23, 2019

@abhirockzz thanks for clarifying for me. 😁

@abhirockzz
Copy link
Contributor Author

@balchua huge props on the NATS streaming scaler!

@balchua
Copy link
Contributor

balchua commented Oct 25, 2019

Thanks!! I forgot to add nats streaming to the list in the readme. I will send a pr to update it. And perhaps an example too.

@ahmelsayed ahmelsayed changed the title removed 'disableScaleToZero' attribute from Prometheus scaled object example removed 'disableScaleToZero' attribute from Prometheus scaled ob… Oct 31, 2019
@ahmelsayed ahmelsayed merged commit 6cbc9db into kedacore:master Oct 31, 2019
preflightsiren pushed a commit to preflightsiren/keda that referenced this pull request Nov 7, 2021
@Ritikaa96
Updating liiklus document: adding optional to lagthreshold (kedacore#392
efa6da7 
)

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@Aarthisk Aarthisk Awaiting requested review from Aarthisk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus scaler "disableScaleToZero" attribute
4 participants
@abhirockzz @tomkerkhove @balchua @ahmelsayed